From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ian@iankelling.org, 17210@debbugs.gnu.org
Subject: bug#17210: 24.3.50; help mode [back] link to a C-h b keybind listing fails with message "Current buffer is not in Help mode"
Date: Mon, 07 Apr 2014 14:17:00 -0400 [thread overview]
Message-ID: <jwvob0dt3i5.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <83ob0d6sow.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Apr 2014 18:54:39 +0300")
> Can you tell why you replaced a literal "*Help*" with a call to
> help-buffer?
I think it's just generally preferable.
> That change was part of your pixel-resizing changes, but
> it doesn't sound related to me, and the ChangeLog entry doesn't
> provide any explanations to convince me otherwise.
> Also, describe-bindings-internal is only called from this single
> place, so I see no reason to support some other help buffers. Do you?
You might have done M-x rename-uniquely.
Does the patch below help?
Stefan
=== modified file 'lisp/help.el'
--- lisp/help.el 2014-04-05 18:33:55 +0000
+++ lisp/help.el 2014-04-07 18:16:00 +0000
@@ -485,8 +485,11 @@
(or buffer (setq buffer (current-buffer)))
(help-setup-xref (list #'describe-bindings prefix buffer)
(called-interactively-p 'interactive))
- (with-current-buffer buffer
- (describe-bindings-internal nil prefix)))
+ (with-help-window (help-buffer)
+ ;; Be aware that `describe-buffer-bindings' puts its output into
+ ;; the current buffer.
+ (with-current-buffer (help-buffer)
+ (describe-buffer-bindings buffer prefix))))
;; This function used to be in keymap.c.
(defun describe-bindings-internal (&optional menus prefix)
@@ -497,6 +500,7 @@
\(Ordinarily these are omitted from the output.)
The optional argument PREFIX, if non-nil, should be a key sequence;
then we display only bindings that start with that prefix."
+ (declare (obsolete describe-buffer-bindings "24.4"))
(let ((buf (current-buffer)))
(with-help-window (help-buffer)
;; Be aware that `describe-buffer-bindings' puts its output into
next prev parent reply other threads:[~2014-04-07 18:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 23:47 bug#17210: 24.3.50; help mode [back] link to a C-h b keybind listing fails with message "Current buffer is not in Help mode" Ian Kelling
2014-04-07 7:48 ` martin rudalics
2014-04-07 15:54 ` Eli Zaretskii
2014-04-07 18:17 ` Stefan Monnier [this message]
2014-04-08 7:14 ` martin rudalics
2014-04-08 8:32 ` Juri Linkov
2014-04-08 9:18 ` martin rudalics
2014-04-08 15:27 ` Eli Zaretskii
2014-04-08 16:34 ` martin rudalics
2014-04-08 16:42 ` Eli Zaretskii
2014-04-08 17:01 ` martin rudalics
2014-04-08 17:08 ` martin rudalics
2014-04-08 17:16 ` Andreas Schwab
2014-04-08 7:13 ` martin rudalics
2014-04-08 15:26 ` Eli Zaretskii
2014-04-08 19:49 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvob0dt3i5.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=17210@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=ian@iankelling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).