bug#17210: 24.3.50; help mode [back] link to a C-h b keybind listing fails with message "Current buffer is not in Help mode"

[Stefan Monnier <monnier@IRO.UMontreal.CA>]

> Can you tell why you replaced a literal "*Help*" with a call to
> help-buffer?

I think it's just generally preferable.

> That change was part of your pixel-resizing changes, but
> it doesn't sound related to me, and the ChangeLog entry doesn't
> provide any explanations to convince me otherwise.

> Also, describe-bindings-internal is only called from this single
> place, so I see no reason to support some other help buffers.  Do you?

You might have done M-x rename-uniquely.
Does the patch below help?


        Stefan


=== modified file 'lisp/help.el'
--- lisp/help.el	2014-04-05 18:33:55 +0000
+++ lisp/help.el	2014-04-07 18:16:00 +0000
@@ -485,8 +485,11 @@
   (or buffer (setq buffer (current-buffer)))
   (help-setup-xref (list #'describe-bindings prefix buffer)
 		   (called-interactively-p 'interactive))
-  (with-current-buffer buffer
-    (describe-bindings-internal nil prefix)))
+  (with-help-window (help-buffer)
+    ;; Be aware that `describe-buffer-bindings' puts its output into
+    ;; the current buffer.
+    (with-current-buffer (help-buffer)
+      (describe-buffer-bindings buffer prefix))))
 
 ;; This function used to be in keymap.c.
 (defun describe-bindings-internal (&optional menus prefix)
@@ -497,6 +500,7 @@
 \(Ordinarily these are omitted from the output.)
 The optional argument PREFIX, if non-nil, should be a key sequence;
 then we display only bindings that start with that prefix."
+  (declare (obsolete describe-buffer-bindings "24.4"))
   (let ((buf (current-buffer)))
     (with-help-window (help-buffer)
       ;; Be aware that `describe-buffer-bindings' puts its output into