unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: 17970-done@debbugs.gnu.org
Subject: bug#17970: log-edit creates unwanted ChangeLog buffers
Date: Wed, 09 Jul 2014 14:54:57 -0400	[thread overview]
Message-ID: <jwvoawynz1g.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <f6egxwtw5g.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 07 Jul 2014 22:35:39 -0400")

> C-x C-b
-> Now there is an empty, unwanted "/tmp/foo/ChangeLog" buffer.

I installed the patch below which seems to fix this problem.


        Stefan


=== modified file 'lisp/vc/log-edit.el'
--- lisp/vc/log-edit.el	2014-07-01 15:15:03 +0000
+++ lisp/vc/log-edit.el	2014-07-09 18:52:47 +0000
@@ -905,6 +905,7 @@
              ;; that memoizing which is undesired here.
              (setq change-log-default-name nil)
              (find-change-log)))))
+    (when (file-exists-p changelog-file-name)
     (with-current-buffer (find-file-noselect changelog-file-name)
       (unless (eq major-mode 'change-log-mode) (change-log-mode))
       (goto-char (point-min))
@@ -942,7 +943,7 @@
                   (setq pos (max (1+ pos) (elt entry 1)))
 		  (goto-char pos)))
 
-	      (cons (current-buffer) texts))))))))
+                (cons (current-buffer) texts)))))))))
 
 (defun log-edit-changelog-insert-entries (buffer beg end &rest files)
   "Insert the text from BUFFER between BEG and END.






  parent reply	other threads:[~2014-07-09 18:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08  2:35 bug#17970: log-edit creates unwanted ChangeLog buffers Glenn Morris
2014-07-09  7:09 ` Glenn Morris
2014-07-09 13:55   ` Eli Zaretskii
2014-07-09 15:41     ` Glenn Morris
2014-07-09 16:28       ` Eli Zaretskii
2014-07-09 16:39         ` Glenn Morris
2014-07-09 16:54           ` Eli Zaretskii
2014-07-09 20:17             ` Glenn Morris
2014-07-10  3:09     ` Stefan Monnier
2014-07-10 14:59       ` Eli Zaretskii
2014-07-10 16:45         ` Stefan Monnier
2014-07-10 16:54           ` Glenn Morris
2014-07-10 17:18             ` Stefan Monnier
2014-07-10 17:22               ` Eli Zaretskii
2014-07-10 17:46               ` Glenn Morris
2014-07-10 18:19                 ` Stefan Monnier
2014-07-09 18:54 ` Stefan Monnier [this message]
2014-07-09 20:19   ` Glenn Morris
2014-07-09 22:22     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvoawynz1g.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=17970-done@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).