From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18545: 24.4.50: Bug - forward-line inside with-selected-window Date: Fri, 26 Sep 2014 08:48:27 -0400 Message-ID: References: <1532440199.73121411675536923.JavaMail.www@wwinf7125> <83wq8qu9bt.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1411735775 30392 80.91.229.3 (26 Sep 2014 12:49:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 26 Sep 2014 12:49:35 +0000 (UTC) Cc: lompik@voila.fr, 18545@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 26 14:49:28 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XXUxj-0007g4-Om for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Sep 2014 14:49:27 +0200 Original-Received: from localhost ([::1]:48167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXUxj-0001Fs-38 for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Sep 2014 08:49:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXUxY-0001Cn-BZ for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 08:49:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXUxQ-0003By-JF for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 08:49:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXUxQ-0003BU-H1 for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 08:49:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XXUxK-0006IC-L4 for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 08:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Sep 2014 12:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18545 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18545-submit@debbugs.gnu.org id=B18545.141173571224149 (code B ref 18545); Fri, 26 Sep 2014 12:49:02 +0000 Original-Received: (at 18545) by debbugs.gnu.org; 26 Sep 2014 12:48:32 +0000 Original-Received: from localhost ([127.0.0.1]:52861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XXUwp-0006HQ-Th for submit@debbugs.gnu.org; Fri, 26 Sep 2014 08:48:32 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:23866) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XXUwm-0006HG-7N for 18545@debbugs.gnu.org; Fri, 26 Sep 2014 08:48:29 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNFxKjo/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgEnLyMFCws0EhQYDSSIBAjSGReOegeEOAEDqRmBaoNMIQ X-IPAS-Result: ArYGAIDvNVNFxKjo/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgEnLyMFCws0EhQYDSSIBAjSGReOegeEOAEDqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="90940002" Original-Received: from 69-196-168-232.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.232]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 26 Sep 2014 08:48:27 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 2461F861E; Fri, 26 Sep 2014 08:48:27 -0400 (EDT) In-Reply-To: <83wq8qu9bt.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Sep 2014 10:31:18 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93769 Archived-At: > I'm not sure this is related to this bug. The problem here was that > the display engine was not considering for redisplay the window > showing the *Completions* buffer. The patch below fixes that. > === modified file 'src/window.c' > --- src/window.c 2014-09-11 08:47:34 +0000 > +++ src/window.c 2014-09-26 07:28:02 +0000 > @@ -5897,6 +5897,8 @@ and redisplay normally--don't erase and w-> start_at_line_beg = (bytepos == BEGV_BYTE || > FETCH_BYTE (bytepos - 1) == '\n'); > + wset_redisplay (w); > + > set_buffer_internal (obuf); > return Qnil; > } Hmm... Now that make me wonder: Why does (with-selected-window (get-buffer-window "*Completions*") (recenter 5)) require an explicit call to wset_redisplay from recenter, whereas (with-selected-window (get-buffer-window "*Completions*") (forward-line 1)) doesn't need an explicit call to wset_redisplay (or bset_redisplay) from forward-line? Stefan