From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Howard Melman <hmelman@gmail.com>
Cc: 20391-done@debbugs.gnu.org
Subject: bug#20391: 24.5; Info-menu completing-read doesn't use DEF argument
Date: Mon, 27 Apr 2015 00:55:32 -0400 [thread overview]
Message-ID: <jwvoamap3yx.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <4863FB33-9877-41C5-938B-E2C2D4B92854@gmail.com> (Howard Melman's message of "Mon, 20 Apr 2015 20:48:33 -0400")
Version:25.1
> The Info-menu command in info.el uses completing-read but doesn't use the
> DEF argument. As a result, helm fails to choose the right default
> when invoked on an info menu line.
> Doing the obvious and appending "nil nil default" to completing-read
> in the Info-menu call did solve the problem for me with helm and did
> seem to still work without helm, but I'm not completely confident it's
> the correct thing.
It looks correct, so that's what I installed. Thank you.
> The next few lines of Info-menu say it's depending on completing-read
> allowing "" even when require-match is t and "" is invalid, but it just
> seems to be doing so to loop back to read another input.
I think this code can now be simplified, but I wasn't in the mood, so
I left it as is for now.
Stefan
prev parent reply other threads:[~2015-04-27 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 0:48 bug#20391: 24.5; Info-menu completing-read doesn't use DEF argument Howard Melman
2015-04-27 4:55 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvoamap3yx.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=20391-done@debbugs.gnu.org \
--cc=hmelman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).