From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#21350: 25.0.50; Do not automatically include authorization header in HTTP redirects Date: Sat, 29 Aug 2015 11:21:35 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1440861746 27046 80.91.229.3 (29 Aug 2015 15:22:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Aug 2015 15:22:26 +0000 (UTC) Cc: 21350@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 29 17:22:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZVhxO-00055V-Rp for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Aug 2015 17:22:15 +0200 Original-Received: from localhost ([::1]:53052 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVhxN-0005CN-PR for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Aug 2015 11:22:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVhxJ-0005BX-L5 for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2015 11:22:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVhxC-0006Yi-8Q for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2015 11:22:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVhxC-0006Ya-5q for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2015 11:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZVhxB-0002In-Qe for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2015 11:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Aug 2015 15:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21350 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21350-submit@debbugs.gnu.org id=B21350.14408616998821 (code B ref 21350); Sat, 29 Aug 2015 15:22:01 +0000 Original-Received: (at 21350) by debbugs.gnu.org; 29 Aug 2015 15:21:39 +0000 Original-Received: from localhost ([127.0.0.1]:42203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVhwo-0002IC-S6 for submit@debbugs.gnu.org; Sat, 29 Aug 2015 11:21:39 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:52192) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVhwm-0002I3-9g for 21350@debbugs.gnu.org; Sat, 29 Aug 2015 11:21:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A7FgA731xV/8Fw3mhcgxBUgy6FVbtAhH6CTQQCAoE8OhMBAQEBAQEBgQpBBYNdAQEDAVYjBQsLDiYSFBgNJIg3CM8jAQEBAQEBBAEBAQEeizqFBQeELQW1BCNhgVqBWSKCeAEBAQ X-IPAS-Result: A0A7FgA731xV/8Fw3mhcgxBUgy6FVbtAhH6CTQQCAoE8OhMBAQEBAQEBgQpBBYNdAQEDAVYjBQsLDiYSFBgNJIg3CM8jAQEBAQEBBAEBAQEeizqFBQeELQW1BCNhgVqBWSKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161793155" Original-Received: from 104-222-112-193.cpe.teksavvy.com (HELO ceviche.home) ([104.222.112.193]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 29 Aug 2015 11:21:35 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 081596615C; Sat, 29 Aug 2015 11:21:35 -0400 (EDT) In-Reply-To: (Thomas Fitzsimmons's message of "Tue, 25 Aug 2015 22:37:46 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105947 Archived-At: > This patch is required for url-http-ntlm.el to handle redirects. I'd > like someone more familiar with url-http.el to review it. I'm not sure if there is such a someone, to tell you the truth. I can give you comments about Elisp style: + ;; Don't automatically include authorization header in redirect. + ;; If needed it will be regenerated by the relevant auth scheme + ;; when the new request happens. + (setq url-http-extra-headers + (let (result) + (dolist (header url-http-extra-headers) + (if (not (equal (car header) "Authorization")) + (push header result))) + (nreverse result))) IIUC this is like: (let ((a (assoc "Authorization" url-http-extra-headers))) (if a (setq url-http-extra-headers (delq a url-http-extra-headers)))) Tho maybe it should be `remq' rather than `delq'. Stefan