From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#31692: Emacs sometimes drops key events Date: Thu, 07 Jun 2018 14:44:36 -0400 Message-ID: References: <83wovgd2aj.fsf@gnu.org> <87po163v65.fsf@web.de> <83in6yarhe.fsf@gnu.org> <877encq5co.fsf@web.de> <8336y0x9c3.fsf@gnu.org> <87zi078r8n.fsf@web.de> <83efhiwrmj.fsf@gnu.org> <83602uwq3y.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528396992 8871 195.159.176.226 (7 Jun 2018 18:43:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 7 Jun 2018 18:43:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: michael_heerdegen@web.de, radon.neon@gmail.com, 31692@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 07 20:43:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQzsJ-00029v-6b for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jun 2018 20:43:07 +0200 Original-Received: from localhost ([::1]:59725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQzuO-00049X-NN for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jun 2018 14:45:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQzuF-000498-2m for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 14:45:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQzuA-0000fT-5z for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 14:45:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58766) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fQzuA-0000f5-2O for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 14:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fQzu9-0001E0-Mp for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 14:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jun 2018 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31692 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31692-submit@debbugs.gnu.org id=B31692.15283970804661 (code B ref 31692); Thu, 07 Jun 2018 18:45:01 +0000 Original-Received: (at 31692) by debbugs.gnu.org; 7 Jun 2018 18:44:40 +0000 Original-Received: from localhost ([127.0.0.1]:38430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQztn-0001D6-Ld for submit@debbugs.gnu.org; Thu, 07 Jun 2018 14:44:39 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQztm-0001Cz-38 for 31692@debbugs.gnu.org; Thu, 07 Jun 2018 14:44:38 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w57IiaZY001186; Thu, 7 Jun 2018 14:44:36 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 3C0A8660E5; Thu, 7 Jun 2018 14:44:36 -0400 (EDT) In-Reply-To: <83602uwq3y.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Jun 2018 18:52:49 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6303=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6303> : inlines <6684> : streams <1789021> : uri <2654294> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147145 Archived-At: >> I don't understand the (throw 'throw-on-input t) >> (throw throw-on-input t) would make more sense, but in any case we're >> just about to exit that `catch` so throwing won't have any real effect. > I hoped the comment explained that, but evidently not. I think I understood the comment (and the email message before that ;-), and your analysis makes a lot of sense, but AFAICT the "normal" way this special quit-flag value is handled in the C code (see process_quit_flag in src/eval.c) is to - read quit-flag - notice it's `eq`ual to the value of throw-on-input - set quit-flag to nil - throw to the flag's value so the throw is not done to the constant symbol `throw-on-input` but to the value of this variable, and the magic doesn't happen in response to this throw (i.e. it's not done within the implementation of the throw/catch code), but instead it happens before the throw. As a consequence, instead of (throw 'throw-on-input t) we need to throw like (throw throw-on-input t) and we additionally need to (setq quit-flag nil) before that. >> I think instead of (throw 'throw-on-input t) what is needed here is >> >> (setq quit-flag nil) >> >> which will also make the body return nil (rather than t like (throw >> throw-on-input t) would), which I believe is also the right thing. > > I believe we need to return t here, because input did arrive. Indeed, I had missed that So I suggest (progn (setq quit-flag nil) t) We could also use (throw throw-on-input t) after the setq, but I don't see the point since it seems it would give exactly the same result just in a more costly way. Stefan