From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10754: define-minor-mode and doc of derived mode Date: Thu, 28 Jun 2018 21:02:35 -0400 Message-ID: References: <87po12g7x4.fsf@gmail.com> <0edf0759-1044-4c6f-b70a-addebc9078f8@default> <87in6trm00.fsf@gmail.com> <83y3ffypek.fsf@gnu.org> <87fu1lv24d.fsf@gmail.com> <87d0wpurh5.fsf@gmail.com> <87bmc9uhl0.fsf@gmail.com> <87efh1xngb.fsf@gmail.com> <87vaa3zzsu.fsf@gmail.com> <87tvpnzzjr.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1530234065 27703 195.159.176.226 (29 Jun 2018 01:01:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 29 Jun 2018 01:01:05 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 10754@debbugs.gnu.org To: John Shahid Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 29 03:01:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYhmW-00074m-JB for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jun 2018 03:01:00 +0200 Original-Received: from localhost ([::1]:39347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYhoe-0000ld-1V for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Jun 2018 21:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYhoX-0000l5-Tw for bug-gnu-emacs@gnu.org; Thu, 28 Jun 2018 21:03:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYhoU-0000LC-Sf for bug-gnu-emacs@gnu.org; Thu, 28 Jun 2018 21:03:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59395) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYhoU-0000Ky-Q6 for bug-gnu-emacs@gnu.org; Thu, 28 Jun 2018 21:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fYhoU-0003DV-Cb for bug-gnu-emacs@gnu.org; Thu, 28 Jun 2018 21:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jun 2018 01:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10754-submit@debbugs.gnu.org id=B10754.153023416912346 (code B ref 10754); Fri, 29 Jun 2018 01:03:02 +0000 Original-Received: (at 10754) by debbugs.gnu.org; 29 Jun 2018 01:02:49 +0000 Original-Received: from localhost ([127.0.0.1]:39059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYhoG-0003D4-Bs for submit@debbugs.gnu.org; Thu, 28 Jun 2018 21:02:48 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:58373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYhoD-0003Ct-MH for 10754@debbugs.gnu.org; Thu, 28 Jun 2018 21:02:46 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w5T12fQv027418; Thu, 28 Jun 2018 21:02:42 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id A3214660EB; Thu, 28 Jun 2018 21:02:35 -0400 (EDT) In-Reply-To: <87tvpnzzjr.fsf@gmail.com> (John Shahid's message of "Wed, 27 Jun 2018 21:31:52 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6318=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6318> : inlines <6728> : streams <1791043> : uri <2665650> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147933 Archived-At: >> The only problematic modes are those with a large keymaps in the >> docstring. The argument doc paragraph ends up being outside the visible >> area on the screen which feels awkward. That said, I'm feel the benefit >> outweigh this awkwardness. Maybe we could add the paragraph at the first empty line (if there's one), instead of always at the end? But overall, LGTM, Stefan