From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46722: test-map-into fails Date: Wed, 05 Jan 2022 13:35:42 -0500 Message-ID: References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3397"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Glenn Morris , smonnier , Stefan Kangas , contovob@tcd.ie, 46722@debbugs.gnu.org, Lars Ingebrigtsen To: dick Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 05 19:36:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5B8y-0000cz-D6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jan 2022 19:36:16 +0100 Original-Received: from localhost ([::1]:43956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5B8x-0000lQ-1r for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jan 2022 13:36:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5B8k-0000jL-SA for bug-gnu-emacs@gnu.org; Wed, 05 Jan 2022 13:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58441) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5B8k-0006pn-Iz for bug-gnu-emacs@gnu.org; Wed, 05 Jan 2022 13:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5B8k-0008GL-HI for bug-gnu-emacs@gnu.org; Wed, 05 Jan 2022 13:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jan 2022 18:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46722 X-GNU-PR-Package: emacs Original-Received: via spool by 46722-submit@debbugs.gnu.org id=B46722.164140775331744 (code B ref 46722); Wed, 05 Jan 2022 18:36:02 +0000 Original-Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 18:35:53 +0000 Original-Received: from localhost ([127.0.0.1]:41754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5B8a-0008Fv-Oa for submit@debbugs.gnu.org; Wed, 05 Jan 2022 13:35:52 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5B8Z-0008Fj-BE for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 13:35:51 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9891D10028A; Wed, 5 Jan 2022 13:35:45 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4535910013B; Wed, 5 Jan 2022 13:35:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641407744; bh=TfO9Wn9BUgqZfxfPL35DknUBD6BFDug07WCxLQNiUxE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=clTf+HSsB+bMWtCLHDojCd6Y9rp5xc9/nYT0BXsJTRk+FCYyIhtRF3DcufeTYmN3m QG9CDTlv7LhWZs2xh3xjUVoppvPYZMO4NGW3b1dj8xsCdxx38JbgpzD7LdtX1xbZC/ jvC7vNRCCe82x1bequZffMDf2k+yGT7EfJZa+z1uK6Gnam3VXP5KWVveaPtrStFjw6 mraTjmmzh7NsB2zwPN/IpQPfO7v7CuzZi1+gngBLt7EkgNw1RDz76l7x8axCmfomvv iS/qcYjwWvETJhCLuGtolL4xy9WbOuIXpmveBze975Epvc9J/3/lW2kLacaTDaIPuE P5PL7jbewwK2w== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 001DC1204D7; Wed, 5 Jan 2022 13:35:43 -0500 (EST) In-Reply-To: <87czl7w4fh.fsf@dick> (dick's message of "Tue, 04 Jan 2022 16:56:34 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223708 Archived-At: > Also in same function, `method-cache` buys you nothing, so getting rid of > it along with `with-memoization` and `(require subr-x)` is a not > insubstantial win. The benefit of the `cl--generic-dispatchers` cache is probably negligible in terms of performance, indeed. Its main purpose is to try and avoid loading the byte-compiler (e.g. most crucially, it saves us from *pre*loading the byte-compiler). The benefit of the `method-cache` OTOH should be very significant since without it we'd have to recompute the effective method at every call. This said, I have not measured it. Stefan