From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame Date: Sat, 16 Jul 2022 19:39:10 -0400 Message-ID: References: <5d86d890-9a2e-e4d6-13fb-da03285ea003@gmx.at> <61fe102b-eec2-9711-560e-c141ed3cc6e4@gmx.at> <171bab25-5eb2-884b-5c32-bcfe4fed21cc@gmx.at> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3757"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Alan Mackenzie , Eli Zaretskii , 56305@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 17 01:40:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCrOd-0000qM-3I for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Jul 2022 01:40:27 +0200 Original-Received: from localhost ([::1]:57060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCrOb-00043z-UL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 19:40:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCrOE-00043j-Mz for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 19:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCrOE-0004nf-Eh for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 19:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCrOE-0002aD-98 for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 19:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jul 2022 23:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56305 X-GNU-PR-Package: emacs Original-Received: via spool by 56305-submit@debbugs.gnu.org id=B56305.16580147659881 (code B ref 56305); Sat, 16 Jul 2022 23:40:02 +0000 Original-Received: (at 56305) by debbugs.gnu.org; 16 Jul 2022 23:39:25 +0000 Original-Received: from localhost ([127.0.0.1]:46356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCrNc-0002ZJ-US for submit@debbugs.gnu.org; Sat, 16 Jul 2022 19:39:25 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCrNa-0002Z5-Tb for 56305@debbugs.gnu.org; Sat, 16 Jul 2022 19:39:23 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 747F7100136; Sat, 16 Jul 2022 19:39:17 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9DB1F10010C; Sat, 16 Jul 2022 19:39:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1658014751; bh=UnhWRk8EkZ8n/fRcplCAi0ogLPKDkJoFQbXV5SJa9dk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lJo0/JcSFucx+p8MsBa/l7nqTs1r2kT+7VrAY/0lxAx3aiHqlL64O2eV1wLTiOn6U INiPR/0++ZMXSPvNHpTKv/+YM2WpsFsKgUo4MANbrT3rO1B0Q0Sz9233Den7Ww0weJ 7dt+4/8EsoKYtQfXnvmCYKmpbLDSXDtn4McPw3Yo2xlLymQMuUUN+Axlrxhf+S696F f9ONFIVGYGsDycfy57bo1WDnhqlWNA3twChxlvoBRFfiS3oqAcqd4oLwG3ohB8IEaM hiMeFJfVevsVoyJbju4NDDp+Dw71RaJvAhMaoWqDhLiHSQwwJ2nRHYFyDj0UzRyMI0 dhUew9sNF71vg== Original-Received: from alfajor (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5E43012034C; Sat, 16 Jul 2022 19:39:11 -0400 (EDT) In-Reply-To: <171bab25-5eb2-884b-5c32-bcfe4fed21cc@gmx.at> (martin rudalics's message of "Tue, 12 Jul 2022 09:35:00 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237217 Archived-At: > You're barking at the wrong tree. That code worked well for half of its > lifetime. What really got us into the present bredouille was commit > 6355802033d202c63f6fff4b77bf2b0c7aecceef and its ill-fated decision to > call Fselect_window instead of directly setting selected frame and > window as the well-established and tested code in display_mode_lines > did and still does. In case you intend to fix this apparent blunder of mine: the point of that commit was to set the selected window and frame so that ELisp code run from the `mode-line-format` would see meaningful and consistent values of selected-frame/window (and companions like the frame-selected-window of the selected-frame, ...). If calling `Fselect_window` with a non-nil `norecord` argument messes things up somehow then maybe we should fix `Fselect_window` accordingly, or otherwise provide a "more bare bones" function that DTRT. It seems clear to me, for example, that when called with a non-nil `norecord` (like in the mode-line code), `Fselect_window` should never cause any change to the focus redirection (or the focus itself). And neither should it call things like `resize_mini_window`, I think. > In the sequel, obscure bugs began to pile up, all very difficult to > describe and reproduce (Bug#23124, Bug#24285, Bug#34317) and were fixed > with some trickery. The origin of all that evil remained in place. I can't see the connection between these bugs at the above commit, sorry. Stefan