From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62762: 'make' often errors with "Org version mismatch" after pulling a new version of the code Date: Sun, 30 Apr 2023 21:48:50 -0400 Message-ID: References: <17b74a48-94e1-9106-cc79-d31972313910@gutov.dev> <837cujaqzq.fsf@gnu.org> <87wn2ilwed.fsf@localhost> <83zg7ealrd.fsf@gnu.org> <87pm8a8dx4.fsf@localhost> <87pm7vt0mx.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4282"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: bzg@gnu.org, dmitry@gutov.dev, Eli Zaretskii , 62762@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 01 03:49:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptIfC-0000tx-P8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 May 2023 03:49:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptIf3-0002Vb-Cm; Sun, 30 Apr 2023 21:49:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptIf1-0002VD-6r for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2023 21:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptIf0-0008Ua-V2 for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2023 21:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptIf0-0006Yl-EM for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2023 21:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 01:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62762 X-GNU-PR-Package: emacs Original-Received: via spool by 62762-submit@debbugs.gnu.org id=B62762.168290574025207 (code B ref 62762); Mon, 01 May 2023 01:49:02 +0000 Original-Received: (at 62762) by debbugs.gnu.org; 1 May 2023 01:49:00 +0000 Original-Received: from localhost ([127.0.0.1]:38597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptIey-0006YV-Gd for submit@debbugs.gnu.org; Sun, 30 Apr 2023 21:49:00 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptIew-0006YG-MR for 62762@debbugs.gnu.org; Sun, 30 Apr 2023 21:48:59 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 15F594416E1; Sun, 30 Apr 2023 21:48:53 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D679D441560; Sun, 30 Apr 2023 21:48:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1682905731; bh=WEBXdQjgF99LgF/wVx07Lbm6Wv0tGtobjBme20wU0lU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TBruRU4CoXsxb5CEz99ooLTM/YaS2XLXWoyYzIK0AYMP+F39DqBjCmCvVpuliwY5J TSzP2Wp86MyNVHeqqdqUOO10kXcBFThg8KN0VpygJb2obsHIWNdZVg0X7RYFGxiAGq 5v7SBT7nhYDhcl9f6KoJzPdYprNNnfx8lvIzCmVWTEu38457UQNh8dzIVeLPABg7+P MqHRx635K6T1xcwmlAesEGMliPjs/5F54fFc+3HQzQzwj1l/8i+lvVzQOTr5nAuMDo YQ1sx+65BQcHD7YYlb79ZanFk8JH7wxlCMk0Qr+YVk3Z7hKnuZX5A8BnQhT723xpnL EIzY9qIg6ILtQ== Original-Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 94726120312; Sun, 30 Apr 2023 21:48:51 -0400 (EDT) In-Reply-To: <87pm7vt0mx.fsf@localhost> (Ihor Radchenko's message of "Sun, 23 Apr 2023 09:21:10 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260847 Archived-At: >> BTW, have you tried to use a test along the lines of: look through >> `load-history` to see if we loaded org-* files from a different directory >> than the one in which `load-file-name` resides? > > Yup. Several problems here: > 1. Not all the org-* files are a part of Org. Ah right, we can't just match "org-*", indeed. Maybe if we can identify a "first org-*.el file" (i.e. a file which *any* use of some part of Org mode would necessarily load pretty early on), then we can reduce this check to: - check if that "first org-*.el file" is already loaded. - if no, load it - if yes, compare the output of `locate-file` to what is found in `load-history`, and in case it doesn't match (because of a new directory in `load-path`), signal an error (or maybe force a reload instead?). We could even provide a new `require-with-shadow-check` function that does just that. Stefan