From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work Date: Mon, 23 Oct 2023 18:36:11 -0400 Message-ID: References: <1d9187b71e7288eaf08ac9a2f0559bdf@gmail.com> <8334y4s0oe.fsf@gnu.org> <83v8axmbsh.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18019"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 24 00:38:54 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qv3ZV-0004Rq-T3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Oct 2023 00:38:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qv3ZC-0003Kq-Dq; Mon, 23 Oct 2023 18:38:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qv3ZB-0003KG-AQ for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 18:38:33 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qv3ZB-00088U-2J for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 18:38:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qv3Zd-0001Pw-Rz for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 18:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Oct 2023 22:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66655 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 66655-submit@debbugs.gnu.org id=B66655.16981007375439 (code B ref 66655); Mon, 23 Oct 2023 22:39:01 +0000 Original-Received: (at 66655) by debbugs.gnu.org; 23 Oct 2023 22:38:57 +0000 Original-Received: from localhost ([127.0.0.1]:52486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qv3ZZ-0001Pe-Hx for submit@debbugs.gnu.org; Mon, 23 Oct 2023 18:38:57 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qv3ZW-0001PQ-KN for 66655@debbugs.gnu.org; Mon, 23 Oct 2023 18:38:55 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 052F1807D1; Mon, 23 Oct 2023 18:38:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1698100698; bh=I+uT2xtL+iYrNVovbx9lFBJAUmMjzC3TJQWKfycrzVY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OTPw2Dr/pZmX5QkdXNbKi7mlDGBda+nDT2J/YHjD4pWL1du5IuqjzFNSrj9fo0lCD P0EAsJRH53AqD0DlZzjnRERc/v5CCTANwr98/Z1X4eiOHvlRoqN2KyAdbZNuhMrklq 4LviYs7WH0owV8WbyLDq1AiVVq17bMaH6awpOA0OAt3GV7idrMipgDAF2wwcQAlnfK MgjzDdBpyjmm2VKWZ9wRO1Q7r8tgkbQJc7ZbrzVu6pxK0xuOJsDx6X02QYfVVzZs7U qEeA/6NqIoFBztV7JAOoNarIaoebvcJx2iSJvxQ4OJLKNJKs9MlQzZGAJzoidysZRv W6lOmIhUrPVTA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B5D0A8044C; Mon, 23 Oct 2023 18:38:18 -0400 (EDT) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A94441207CC; Mon, 23 Oct 2023 18:38:18 -0400 (EDT) In-Reply-To: <83v8axmbsh.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 23 Oct 2023 21:30:38 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273068 Archived-At: > Yes, that's the logic here. Technically, it happens because clicking > the mouse emits 2 events: down-mouse-1 followed by another one caused > by releasing the mouse button, and the first event could cause > redisplay (as happens in this case) because it generally moves point > to the location of the click. So maybe, in order to upgrade an `up` to a `drag` we should check that: - the end (buffer) position is different. - and the mouse has actually moved. Currently we detect a mouse-has-moved when the start and end (screen) position of the mouse are different, but maybe we should additionally set a flag when the mouse is moved, so that it's still considered as "moved" if the mouse returns to its initial (screen) position? Stefan