From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#179: 23.0.60; Menu separators are not displayed Date: Fri, 08 Aug 2008 14:31:36 -0400 Message-ID: References: <87vdyf86vq.fsf@stupidchicken.com> <85ljzb8668.fsf@lola.goethe.zz> Reply-To: Stefan Monnier , 179@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1218497372 2798 80.91.229.12 (11 Aug 2008 23:29:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Aug 2008 23:29:32 +0000 (UTC) Cc: Chong Yidong , 179@emacsbugs.donarmstrong.com To: David Kastrup Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 12 01:30:23 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KSgpn-0004Il-7Q for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Aug 2008 01:29:55 +0200 Original-Received: from localhost ([127.0.0.1]:55643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSgor-0006Zg-5F for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Aug 2008 19:28:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSgnY-0005aZ-1g for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2008 19:27:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSgnW-0005YL-3j for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2008 19:27:35 -0400 Original-Received: from [199.232.76.173] (port=55801 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSgnV-0005Y2-P0 for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2008 19:27:33 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:57859) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KSgnV-0006f1-9H for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2008 19:27:33 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7BNRO1Q017788; Mon, 11 Aug 2008 16:27:26 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m7BNA9WW012347; Mon, 11 Aug 2008 16:10:09 -0700 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 11 Aug 2008 23:10:09 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 179 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: moreinfo patch Original-Received: via spool by 179-submit@emacsbugs.donarmstrong.com id=B179.12184957099530 (code B ref 179); Mon, 11 Aug 2008 23:10:09 +0000 Original-Received: (at 179) by emacsbugs.donarmstrong.com; 11 Aug 2008 23:01:49 +0000 Original-Received: from smtp-05.arnet.com.ar (smtp-05.arnet.com.ar [200.45.191.5]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m7BN1euU009468 for <179@emacsbugs.donarmstrong.com>; Mon, 11 Aug 2008 16:01:42 -0700 Original-Received: (qmail 2771 invoked from network); 11 Aug 2008 16:59:44 -0000 Original-Received: from unknown (HELO ceviche.home) (190.30.131.157) by 0 with SMTP; 11 Aug 2008 16:59:43 -0000 Original-Received: by ceviche.home (Postfix, from userid 20848) id 6878DB41C7; Fri, 8 Aug 2008 14:31:36 -0400 (EDT) In-Reply-To: <85ljzb8668.fsf@lola.goethe.zz> (David Kastrup's message of "Wed, 06 Aug 2008 00:10:07 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Mon, 11 Aug 2008 19:27:35 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19307 Archived-At: >> Did you ever get the chance to try Stefan's patch from May? >> >> >> Stefan Monnier wrote: >> >>> Does the patch below fix it? >>> >>> Stefan >> >> --- subr.el.~1.594.~ 2008-05-02 12:47:05.000000000 -0400 >> +++ subr.el 2008-05-05 02:58:00.000000000 -0400 >> @@ -571,10 +571,14 @@ >> (let* ((key (car binding)) >> (item (cdr binding)) >> (oldbind (assq key bindings))) >> + (if (null key) >> + ;; nil keys are/were used by easy-menu for "separator lines and >> + ;; separator titles". Merging them makes no sense. >> + (push binding bindings) >> ;; Newer bindings override older. >> (if oldbind (setq bindings (delq oldbind bindings))) >> (when item ;nil bindings just hide older ones. >> - (push binding bindings)))) >> + (push binding bindings))))) >> (nconc map bindings))) >> >> (put 'keyboard-translate-table 'char-table-extra-slots 0) >> > My current Emacs does not have this patch applied (or include the > equivalent) and does show menu separators. So at least the problem I > reported would appear to be fixed (I am judging from the subject line of > the bug report, don't have the report itself here). Indeed, IIRC I installed a different patch for this problem. It turns out that the nil binding is actually not special in any way and that most separators use other names than nil, so I changed easy-menu to not use nil either, which makes the above patch unneeded (and probably undesirable either). Stefan