From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#731: 23.0.60; Varying point position after undo Date: Sun, 21 Sep 2008 15:30:04 -0400 Message-ID: References: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> <48D36604.7020702@gmx.at> <48D636ED.3020103@gmx.at> Reply-To: Stefan Monnier , 731@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1222026473 804 80.91.229.12 (21 Sep 2008 19:47:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Sep 2008 19:47:53 +0000 (UTC) Cc: Markus Triska , 731@emacsbugs.donarmstrong.com, cyd@MIT.EDU To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 21 21:48:50 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KhUvJ-0002rB-QZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Sep 2008 21:48:50 +0200 Original-Received: from localhost ([127.0.0.1]:56832 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KhUuH-0007LP-TJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Sep 2008 15:47:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KhUuD-0007L9-Rz for bug-gnu-emacs@gnu.org; Sun, 21 Sep 2008 15:47:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KhUuB-0007Kl-Aq for bug-gnu-emacs@gnu.org; Sun, 21 Sep 2008 15:47:40 -0400 Original-Received: from [199.232.76.173] (port=44068 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KhUuB-0007Ki-1R for bug-gnu-emacs@gnu.org; Sun, 21 Sep 2008 15:47:39 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:35823) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KhUuA-0004dE-9z for bug-gnu-emacs@gnu.org; Sun, 21 Sep 2008 15:47:38 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8LJla1L005436; Sun, 21 Sep 2008 12:47:36 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m8LJe7Pl002186; Sun, 21 Sep 2008 12:40:07 -0700 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 21 Sep 2008 19:40:06 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 731 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 731-submit@emacsbugs.donarmstrong.com id=B731.122202541731513 (code B ref 731); Sun, 21 Sep 2008 19:40:06 +0000 Original-Received: (at 731) by emacsbugs.donarmstrong.com; 21 Sep 2008 19:30:17 +0000 Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8LJUB3k031006 for <731@emacsbugs.donarmstrong.com>; Sun, 21 Sep 2008 12:30:15 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjkGAA4+1kjO+KDT/2dsb2JhbACBXbJ3gWaBBA X-IronPort-AV: E=Sophos;i="4.32,441,1217822400"; d="scan'208";a="27198933" Original-Received: from 206-248-160-211.dsl.teksavvy.com (HELO ceviche.home) ([206.248.160.211]) by ironport2-out.teksavvy.com with ESMTP; 21 Sep 2008 15:30:04 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id BC86EB40B1; Sun, 21 Sep 2008 15:30:04 -0400 (EDT) In-Reply-To: <48D636ED.3020103@gmx.at> (martin rudalics's message of "Sun, 21 Sep 2008 13:58:37 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sun, 21 Sep 2008 15:47:40 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20688 Archived-At: > ! if ((current_buffer != last_undo_buffer) > ! /* Don't make an undo boundary when record_first_change will do it > ! anyway. */ > ! && (MODIFF > SAVE_MODIFF)) Hmm.. the comment seems to say that calling it is just redundant, whereas this thread shows that it can actually be harmful. Could you improve the comment so as to explain why it's harmful? Stefan