From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: Markus Triska <markus.triska@gmx.at>,
731@emacsbugs.donarmstrong.com, cyd@MIT.EDU
Subject: bug#731: 23.0.60; Varying point position after undo
Date: Sun, 21 Sep 2008 15:30:04 -0400 [thread overview]
Message-ID: <jwvmyi12t9t.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <48D636ED.3020103@gmx.at> (martin rudalics's message of "Sun, 21 Sep 2008 13:58:37 +0200")
> ! if ((current_buffer != last_undo_buffer)
> ! /* Don't make an undo boundary when record_first_change will do it
> ! anyway. */
> ! && (MODIFF > SAVE_MODIFF))
Hmm.. the comment seems to say that calling it is just redundant,
whereas this thread shows that it can actually be harmful.
Could you improve the comment so as to explain why it's harmful?
Stefan
next prev parent reply other threads:[~2008-09-21 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 3:26 bug#731: 23.0.60; Varying point position after undo cyd
2008-09-19 4:31 ` Markus Triska
2008-09-19 8:42 ` martin rudalics
2008-09-19 13:23 ` Markus Triska
2008-09-21 11:58 ` martin rudalics
2008-09-21 12:31 ` Markus Triska
2008-09-21 19:30 ` Stefan Monnier [this message]
2008-09-22 15:59 ` martin rudalics
2008-09-22 17:40 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2008-08-16 16:59 Markus Triska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmyi12t9t.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=731@emacsbugs.donarmstrong.com \
--cc=cyd@MIT.EDU \
--cc=markus.triska@gmx.at \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).