From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4879: Crash in xmenu_show Date: Sat, 07 Nov 2009 22:43:01 -0500 Message-ID: References: <87aayzchne.fsf@stupidchicken.com> Reply-To: Stefan Monnier , 4879@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1257653260 27142 80.91.229.12 (8 Nov 2009 04:07:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Nov 2009 04:07:40 +0000 (UTC) Cc: 4879@emacsbugs.donarmstrong.com To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 08 05:07:32 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N6z3s-0003AL-HP for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Nov 2009 05:07:32 +0100 Original-Received: from localhost ([127.0.0.1]:33101 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N6z3r-00043f-Rj for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Nov 2009 23:07:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N6z3m-000423-UE for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2009 23:07:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N6z3i-0003xE-Cn for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2009 23:07:26 -0500 Original-Received: from [199.232.76.173] (port=44366 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N6z3i-0003wq-22 for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2009 23:07:22 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37263) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N6z3h-0006M9-EM for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2009 23:07:21 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA847HOZ013330; Sat, 7 Nov 2009 20:07:19 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nA83t7Nr011629; Sat, 7 Nov 2009 19:55:07 -0800 Resent-Date: Sat, 7 Nov 2009 19:55:07 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sun, 08 Nov 2009 03:55:07 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4879 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4879-submit@emacsbugs.donarmstrong.com id=B4879.125765197611116 (code B ref 4879); Sun, 08 Nov 2009 03:55:07 +0000 Original-Received: (at 4879) by emacsbugs.donarmstrong.com; 8 Nov 2009 03:46:16 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA83kDlY011113 for <4879@emacsbugs.donarmstrong.com>; Sat, 7 Nov 2009 19:46:15 -0800 Original-Received: from ceviche.home (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id nA83kBAf020627; Sat, 7 Nov 2009 22:46:11 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id EA237B40E4; Sat, 7 Nov 2009 22:43:01 -0500 (EST) In-Reply-To: <87aayzchne.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 06 Nov 2009 19:17:41 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3401=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sat, 07 Nov 2009 23:07:26 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32473 Archived-At: >>>>> "Chong" == Chong Yidong writes: >> Program received signal SIGSEGV, Segmentation fault. >> [Switching to Thread 0x7fb3746be7a0 (LWP 19530)] >> 0x00000000004701c7 in xmenu_show (f=0x11c46e0, x=227, y=29, for_click=1, keymaps=1, title=12708355, error=0x7fff7c6ed8c0) at xmenu.c:2735 >> 2735 bcopy (SDATA (item_name), item_data, > The problem is that > XVECTOR (menu_items)->contents[i + MENU_ITEMS_ITEM_EQUIV_KEY]; > is now a symbol, but the code (here and in a couple of other places in > xmenu.c, and maybe elsewhere) assumes that it's a string or nil. > It's simple to "fix" by adding an additional check for symbols as menu > descriptors, but we need to understand why the situation has changed. > Stefan, I'm 99% sure this was caused by your keymap changes around > 2009-09-11. Could you please debug them? Hmm... not sure how it relates, but I see one possible trouble spot. Does the patch below help? Stefan --- keyboard.c.~1.1016.~ 2009-10-24 22:39:01.000000000 -0400 +++ keyboard.c 2009-11-07 22:41:50.000000000 -0500 @@ -8118,6 +8118,8 @@ tem = concat2 (build_string (" "), tem); /* tem = concat3 (build_string (" ("), tem, build_string (")")); */ } + else + tem = Qnil; }