unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: cyd@stupidchicken.com, 7840@debbugs.gnu.org
Subject: bug#7840: SYMBOL_VALUE in terminal.c (was 23.2.91; default-terminal-coding-system not inherited by created terminals)
Date: Fri, 18 Feb 2011 16:35:18 -0500	[thread overview]
Message-ID: <jwvmxltrpyn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83fwrlutf4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Feb 2011 19:46:55 +0200")

> I also don't understand the "internal function" argument: it sounds
> TRT to have a function that just fetches a symbol's value, without
> signaling an error if it is unbound.  Fsymbol_value, as it is now, is
> clearly coded for interactive use, which this isn't.

You mean "Lisp use" rather than "interactive", right?

> In any case, if you want people to avoid these APIs, please explain
> more why you dislike them, because so far it is utterly unclear, at
> least to me.

Basically Emacs variables provide
get/set/letbind/unbind/boundp/make-local/makunbound and everything else
is internal.  Any code which is not directly related to implementing
that functionality should go through those entry points, IMO.

find_symbol_value is the least harmful of the internal functions,
indeed, but it still requires extra care from the caller since it can
return Qunbound which is a value which should never escape to Lisp code.


        Stefan





  reply	other threads:[~2011-02-18 21:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-14  3:45 bug#7840: 23.2.91; default-terminal-coding-system not inherited by created terminals Eli Zaretskii
2011-01-14 15:33 ` Stefan Monnier
2011-02-12  9:55   ` Eli Zaretskii
2011-02-13  0:18 ` bug#7840: SYMBOL_VALUE in terminal.c (was 23.2.91; default-terminal-coding-system not inherited by created terminals) Chong Yidong
2011-02-14 18:05   ` Stefan Monnier
2011-02-18 14:51     ` Eli Zaretskii
2011-02-18 17:33       ` Stefan Monnier
2011-02-18 17:46         ` Eli Zaretskii
2011-02-18 21:35           ` Stefan Monnier [this message]
2011-02-19  8:05             ` bug#7840: SYMBOL_VALUE in terminal.c Eli Zaretskii
2011-02-19 21:14               ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmxltrpyn.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=7840@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).