From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#9820: 24.0.90; Behaviour of add-file-local-variable Date: Sun, 23 Oct 2011 13:59:14 -0400 Message-ID: References: <8162jjj5dp.fsf@gmail.com> <87ehy61n79.fsf@mail.jurta.org> <8139el1v3i.fsf@gmail.com> <81vcrhzid5.fsf@gmail.com> <87fwilkqck.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1319392787 30199 80.91.229.12 (23 Oct 2011 17:59:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 23 Oct 2011 17:59:47 +0000 (UTC) Cc: Jambunathan K , 9820@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 23 19:59:43 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RI2Ki-000335-Bb for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Oct 2011 19:59:40 +0200 Original-Received: from localhost ([::1]:38972 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RI2Kh-000676-QI for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Oct 2011 13:59:39 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:36728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RI2Ke-00065I-QQ for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2011 13:59:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RI2Kd-0001eo-OJ for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2011 13:59:36 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RI2Kd-0001ek-La for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2011 13:59:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RI2M1-0004Bl-PX for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2011 14:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Oct 2011 18:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9820 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9820-submit@debbugs.gnu.org id=B9820.131939285516090 (code B ref 9820); Sun, 23 Oct 2011 18:01:01 +0000 Original-Received: (at 9820) by debbugs.gnu.org; 23 Oct 2011 18:00:55 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RI2Lu-0004BT-To for submit@debbugs.gnu.org; Sun, 23 Oct 2011 14:00:55 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RI2Lt-0004BH-Qc for 9820@debbugs.gnu.org; Sun, 23 Oct 2011 14:00:54 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAM1VpE5MCqLO/2dsb2JhbABDqRGBBoFuAQEEAVYjBQsLNBIUGA0kiBO1AYhABKE7hEU X-IronPort-AV: E=Sophos;i="4.69,394,1315195200"; d="scan'208";a="144006702" Original-Received: from 76-10-162-206.dsl.teksavvy.com (HELO pastel.home) ([76.10.162.206]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 23 Oct 2011 13:59:14 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7437358B4A; Sun, 23 Oct 2011 13:59:14 -0400 (EDT) In-Reply-To: <87fwilkqck.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 22 Oct 2011 18:35:47 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 23 Oct 2011 14:01:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53040 Archived-At: > After moving this message to modify-file-local-variable, > checking for new value against the old value really makes less sense > because it's unclear what to do for the `delete' operations, > so I removed this check below. I think it's important to silence the message when we can know that it's not useful (i.e. the variable already has the right value). For `delete', we can test local-variable-p. BTW, I think the message is not yet as good as it should be. E.g. we could either tell the exact command that needs to be used (e.g. M-x revert-buffer), or go the other way and only point out the current situation without indicating how to "fix" it, something like "the change hasn't yet taken effect". Stefan