unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo Liu <sdl.web@gmail.com>
Cc: 17630@debbugs.gnu.org
Subject: bug#17630: 24.3.91; gv expander for a few places are incorrect
Date: Fri, 30 May 2014 12:20:49 -0400	[thread overview]
Message-ID: <jwvmwdzfdh3.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <m3ha48dj3p.fsf@gmail.com> (Leo Liu's message of "Fri, 30 May 2014 11:46:18 +0800")

> Yes but the situation is both odd and logical. Due to the naming of the
> setter the WINDOW arg naturally should appear first. For example:
>   (set-window-parameter PARAMETER VALUE &optional WINDOW)
> is less clear. Making the WINDOW arg required in the getter has
> downsides as well.

Indeed.  So I guess the better fix is to use gv-define-setter, indeed.
BTW, IIRC these setter definitions come straight from the old CL code,
so this bug has been with us for a while.


        Stefan





  reply	other threads:[~2014-05-30 16:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 11:36 bug#17630: 24.3.91; gv expander for a few places are incorrect Leo Liu
2014-05-29 13:18 ` Stefan Monnier
2014-05-30  3:46   ` Leo Liu
2014-05-30 16:20     ` Stefan Monnier [this message]
2014-05-31  3:04       ` Leo Liu
2014-05-31 14:32         ` Stefan Monnier
2014-05-31 14:37         ` Stefan Monnier
2014-05-31 15:47           ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmwdzfdh3.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=17630@debbugs.gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).