From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13948: no key-binding-locus Date: Wed, 04 Jun 2014 09:50:17 -0400 Message-ID: References: <87k38zipmh.fsf@geodiff-mac3.ulb.ac.be> <87k38xhrqr.fsf@yahoo.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1401889894 25560 80.91.229.3 (4 Jun 2014 13:51:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Jun 2014 13:51:34 +0000 (UTC) Cc: 13948@debbugs.gnu.org, Brian Malehorn To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 04 15:51:27 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WsBbC-0002Tl-Uu for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Jun 2014 15:51:27 +0200 Original-Received: from localhost ([::1]:33526 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsBbC-000500-Iu for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Jun 2014 09:51:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsBaz-0004zQ-SC for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2014 09:51:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsBap-0005Gx-O6 for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2014 09:51:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsBap-0005Gq-LD for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2014 09:51:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WsBao-0003wH-P4 for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2014 09:51:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jun 2014 13:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13948 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13948-submit@debbugs.gnu.org id=B13948.140188983114837 (code B ref 13948); Wed, 04 Jun 2014 13:51:02 +0000 Original-Received: (at 13948) by debbugs.gnu.org; 4 Jun 2014 13:50:31 +0000 Original-Received: from localhost ([127.0.0.1]:43298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsBaE-0003qg-89 for submit@debbugs.gnu.org; Wed, 04 Jun 2014 09:50:31 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49725) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsBa7-0003qJ-It for 13948@debbugs.gnu.org; Wed, 04 Jun 2014 09:50:24 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s54DoHxS012678; Wed, 4 Jun 2014 09:50:17 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 2EFFFAE23E; Wed, 4 Jun 2014 09:50:17 -0400 (EDT) In-Reply-To: <87k38xhrqr.fsf@yahoo.fr> (Nicolas Richard's message of "Wed, 04 Jun 2014 12:51:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4963=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4963> : inlines <965> : streams <1203153> : uri <1775024> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:89976 Archived-At: > I also provide a rough patch for help-fns--key-bindings to show the > keymap in C-h k. Thanks. But I think this is too wordy. We only want to show the locus for C-h k and not for C-h f (and only show it for the particular key sequence used). > (let ((map (yf/key-binding-keymap key t))) > (if (eq map (current-global-map)) > t > (yf/find-object-in-variables map)))) Why do we need to treat the global map specially? > + "Describe key and its originating keymap" Please punctuate your docstrings. Could you turn it into a self-contained patch (e.g. move the yf/* functions to help*.el and rename it accordingly)? Stefan