From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Nicolas Richard <theonewiththeevillook@yahoo.fr>
Cc: 13948@debbugs.gnu.org, Brian Malehorn <bmalehorn@gmail.com>
Subject: bug#13948: no key-binding-locus
Date: Wed, 04 Jun 2014 09:50:17 -0400 [thread overview]
Message-ID: <jwvmwdshl17.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87k38xhrqr.fsf@yahoo.fr> (Nicolas Richard's message of "Wed, 04 Jun 2014 12:51:56 +0200")
> I also provide a rough patch for help-fns--key-bindings to show the
> keymap in C-h k.
Thanks. But I think this is too wordy. We only want to show the locus
for C-h k and not for C-h f (and only show it for the particular key
sequence used).
> (let ((map (yf/key-binding-keymap key t)))
> (if (eq map (current-global-map))
> t
> (yf/find-object-in-variables map))))
Why do we need to treat the global map specially?
> + "Describe key and its originating keymap"
Please punctuate your docstrings.
Could you turn it into a self-contained patch (e.g. move the yf/*
functions to help*.el and rename it accordingly)?
Stefan
next prev parent reply other threads:[~2014-06-04 13:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 20:34 bug#13948: no key-binding-locus Brian Malehorn
2013-04-23 19:41 ` Josh
2014-06-02 10:15 ` Nicolas Richard
2014-06-02 13:55 ` Stefan Monnier
2014-06-04 10:51 ` Nicolas Richard
2014-06-04 13:50 ` Stefan Monnier [this message]
2014-06-04 14:00 ` Nicolas Richard
2014-06-04 14:20 ` Stefan Monnier
2014-06-06 17:57 ` Nicolas Richard
2014-06-06 18:27 ` Stefan Monnier
2014-06-10 19:46 ` Nicolas Richard
2014-06-10 22:24 ` Stefan Monnier
2014-06-11 11:23 ` Nicolas Richard
2014-06-11 18:06 ` Stefan Monnier
2014-06-11 20:20 ` Nicolas Richard
2014-06-11 22:00 ` Stefan Monnier
2014-06-12 8:16 ` Nicolas Richard
2014-06-12 16:09 ` Nicolas Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmwdshl17.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=13948@debbugs.gnu.org \
--cc=bmalehorn@gmail.com \
--cc=theonewiththeevillook@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).