From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18950: [PATCH] 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled Date: Thu, 15 Jan 2015 10:06:39 -0500 Message-ID: References: <86wq7ai5cz.fsf@yandex.ru> <4fd05af1b84870c40eae10fa421aa17c@samertm.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421334441 2663 80.91.229.3 (15 Jan 2015 15:07:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Jan 2015 15:07:21 +0000 (UTC) Cc: 18950@debbugs.gnu.org, Dmitry Gutov To: samer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 15 16:07:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YBm0v-0004Fk-W1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Jan 2015 16:07:14 +0100 Original-Received: from localhost ([::1]:51187 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBm0v-00086L-9B for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Jan 2015 10:07:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBm0o-00086G-2m for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2015 10:07:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBm0k-0008GE-Rg for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2015 10:07:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBm0k-0008Fh-Os for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2015 10:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YBm0k-0007fS-BF for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2015 10:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jan 2015 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18950-submit@debbugs.gnu.org id=B18950.142133440329445 (code B ref 18950); Thu, 15 Jan 2015 15:07:02 +0000 Original-Received: (at 18950) by debbugs.gnu.org; 15 Jan 2015 15:06:43 +0000 Original-Received: from localhost ([127.0.0.1]:57824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBm0Q-0007eq-Q8 for submit@debbugs.gnu.org; Thu, 15 Jan 2015 10:06:43 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:53762) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBm0P-0007eh-Fc for 18950@debbugs.gnu.org; Thu, 15 Jan 2015 10:06:41 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t0FF6dOa020435; Thu, 15 Jan 2015 10:06:40 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 2F51716E8; Thu, 15 Jan 2015 10:06:39 -0500 (EST) In-Reply-To: <4fd05af1b84870c40eae10fa421aa17c@samertm.com> (samer@samertm.com's message of "Wed, 14 Jan 2015 20:12:48 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.4 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.2, LNG_SB_1=0.2, RV5187=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5187> : inlines <1768> : streams <1373836> : uri <1842492> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98371 Archived-At: > - (if (and pcomplete-cycle-completions > - (listp pcomplete-stub) ;?? > + (if (and (listp pcomplete-stub) ;?? I haven't had time to look more closely at the bug and the code, but if this indeed works, then it looks like a good change. Stefan