From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23933: 25.1.50; Run a buffer-local hook with mapc Date: Sun, 10 Jul 2016 17:12:27 -0400 Message-ID: References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> <87furhh0yb.fsf@users.sourceforge.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468185218 9179 80.91.229.3 (10 Jul 2016 21:13:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Jul 2016 21:13:38 +0000 (UTC) Cc: 23933@debbugs.gnu.org, kifer@cs.stonybrook.edu, tino.calancha@gmail.com To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 10 23:13:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMM2N-0002C5-8a for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jul 2016 23:13:15 +0200 Original-Received: from localhost ([::1]:56887 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMM2M-0007pR-9k for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jul 2016 17:13:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMM2F-0007pK-SI for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 17:13:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMM2A-0007rO-R1 for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 17:13:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMM2A-0007rH-Nb for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 17:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bMM2A-0006Pg-Ho for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 17:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jul 2016 21:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23933-submit@debbugs.gnu.org id=B23933.146818515524615 (code B ref 23933); Sun, 10 Jul 2016 21:13:02 +0000 Original-Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 21:12:35 +0000 Original-Received: from localhost ([127.0.0.1]:45714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMM1j-0006Ox-0j for submit@debbugs.gnu.org; Sun, 10 Jul 2016 17:12:35 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:44035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMM1h-0006Oj-Rp for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 17:12:34 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CXDQA731xV/3mcpUVcgxCEAsEVhH6CTQQCAoE8OxIBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA2IWwjPIwEBAQEBAQQBAQEBHos6hQUHFoQXBbM/gUUjhBQigngBAQE X-IPAS-Result: A0CXDQA731xV/3mcpUVcgxCEAsEVhH6CTQQCAoE8OxIBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA2IWwjPIwEBAQEBAQQBAQEBHos6hQUHFoQXBbM/gUUjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="247347534" Original-Received: from 69-165-156-121.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP; 10 Jul 2016 17:12:27 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id EBDBE64151; Sun, 10 Jul 2016 17:12:27 -0400 (EDT) In-Reply-To: <87furhh0yb.fsf@users.sourceforge.net> (npostavs's message of "Sun, 10 Jul 2016 13:12:12 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120822 Archived-At: > (defun ediff-really-quit (reverse-default-keep-variants) > ... > (let (... > (after-quit-hook-internal ediff-after-quit-hook-internal) > And as mentioned in the patch, ediff-filegroup-action calls add-hook > with non-nil LOCAL on ediff-after-quit-hook-internal. And there we have a problem. When t is encountered in the buffer-local part of ediff-after-quit-hook-internal, it means to run the global part of ediff-after-quit-hook-internal, but when we copy the list to after-quit-hook-internal, this link is broken and run-hooks can't know that a t in after-quit-hook-internal means to run the functions found in the global part of ediff-after-quit-hook-internal. Or looked at it another way, this let-binding does not copy the whole content of the hook, only the buffer-local part of it which is not sufficient when the hook has a buffer-local value as well as a non-nil global value. Most likely it works OK in practice because ediff-after-quit-hook-internal typically has a nil global binding. It might make sense to use something like: ;; FIXME: Here we ignore the global part of the ;; ediff-after-quit-hook-internal hook. (after-quit-hook-internal (remq t ediff-after-quit-hook-internal)) -- Stefan