From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13425: close this bug? Date: Sun, 29 Jan 2017 12:16:20 -0500 Message-ID: References: <87efzqhh93.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485710248 32449 195.159.176.226 (29 Jan 2017 17:17:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jan 2017 17:17:28 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 13425@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 29 18:17:21 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXt6D-0006d2-45 for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2017 18:17:09 +0100 Original-Received: from localhost ([::1]:56118 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXt6G-0008Tz-FT for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2017 12:17:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXt69-0008Nb-A8 for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 12:17:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXt66-00083d-3l for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 12:17:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52187) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXt66-00083Z-0v for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 12:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cXt65-0000j4-Jf for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 12:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2017 17:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13425 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13425-submit@debbugs.gnu.org id=B13425.14857101842745 (code B ref 13425); Sun, 29 Jan 2017 17:17:01 +0000 Original-Received: (at 13425) by debbugs.gnu.org; 29 Jan 2017 17:16:24 +0000 Original-Received: from localhost ([127.0.0.1]:50386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXt5U-0000iB-H4 for submit@debbugs.gnu.org; Sun, 29 Jan 2017 12:16:24 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:53131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXt5R-0000i2-NP for 13425@debbugs.gnu.org; Sun, 29 Jan 2017 12:16:22 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v0THGKn4014887; Sun, 29 Jan 2017 12:16:20 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 72BE766261; Sun, 29 Jan 2017 12:16:20 -0500 (EST) In-Reply-To: <87efzqhh93.fsf@tromey.com> (Tom Tromey's message of "Wed, 25 Jan 2017 16:06:16 -0700") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5934=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5934> : inlines <5665> : streams <1730772> : uri <2367042> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128760 Archived-At: > I did spend a bit of time trying to get it to line up continued > properties under the ":", like: > font: 15px "Helvetica Neue", > Helvetica, > Arial, > "Nimbus Sans L", > sans-serif; > ... but all I really accomplished was realizing that I don't understand > SMIE. What have you tried? I don't know the CSS grammar well enough to know what we should do. The above problem is trivially fixed with the patch below, but it seems too easy, so it probably introduces problems elsewhere. Stefan diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index c81c3f62e1..499de8db2e 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -734,7 +734,7 @@ css-indent-offset (defconst css-smie-grammar (smie-prec2->grammar - (smie-precs->prec2 '((assoc ";") (assoc ",") (left ":"))))) + (smie-precs->prec2 '((assoc ";") (left ":") (assoc ","))))) (defun css-smie--forward-token () (cond