From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#25529: diagnosis and one approach to a fix Date: Sat, 11 Feb 2017 10:41:40 -0500 Message-ID: References: <87wpd58ag6.fsf@tromey.com> <87shnt89be.fsf@tromey.com> <87o9yg8qdi.fsf@tromey.com> <87k2948onb.fsf@tromey.com> <183374a4-6469-44af-6ae6-fec02874547a@yandex.ru> <87bmuf8c1l.fsf@tromey.com> <87vash5wag.fsf@tromey.com> <87r3355q2r.fsf@tromey.com> <8737fk694n.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1486827735 8457 195.159.176.226 (11 Feb 2017 15:42:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 11 Feb 2017 15:42:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 25529@debbugs.gnu.org, Dmitry Gutov To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 11 16:42:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccZoO-0001ma-7L for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Feb 2017 16:42:08 +0100 Original-Received: from localhost ([::1]:48719 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccZoT-00057S-Pw for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Feb 2017 10:42:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccZoN-00057B-79 for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2017 10:42:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccZoI-0006kN-BS for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2017 10:42:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37648) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ccZoI-0006kJ-8s for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2017 10:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ccZoI-0005FF-0E for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2017 10:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Feb 2017 15:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25529 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25529-submit@debbugs.gnu.org id=B25529.148682770920141 (code B ref 25529); Sat, 11 Feb 2017 15:42:01 +0000 Original-Received: (at 25529) by debbugs.gnu.org; 11 Feb 2017 15:41:49 +0000 Original-Received: from localhost ([127.0.0.1]:35847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccZo5-0005Em-BO for submit@debbugs.gnu.org; Sat, 11 Feb 2017 10:41:49 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:6064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccZo3-0005EZ-1w for 25529@debbugs.gnu.org; Sat, 11 Feb 2017 10:41:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AbKQAu3EVY//7rSC1dGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+EW4VUnAImAZZehhwEAgKCEUQQAQIBAQEBAQEBYiiEaQEEAVYjBQsLNBIUGA0kiHoIrRSLRAEBAQcCASSLGYopBY98imqSc4gnhjqSDzYgeBMOhXMgiS0BAQE X-IPAS-Result: A0AbKQAu3EVY//7rSC1dGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+EW4VUnAImAZZehhwEAgKCEUQQAQIBAQEBAQEBYiiEaQEEAVYjBQsLNBIUGA0kiHoIrRSLRAEBAQcCASSLGYopBY98imqSc4gnhjqSDzYgeBMOhXMgiS0BAQE X-IronPort-AV: E=Sophos;i="5.33,749,1477972800"; d="scan'208";a="292650621" Original-Received: from 45-72-235-254.cpe.teksavvy.com (HELO ceviche.home) ([45.72.235.254]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Feb 2017 10:41:40 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 4649B66206; Sat, 11 Feb 2017 10:41:40 -0500 (EST) In-Reply-To: <8737fk694n.fsf@tromey.com> (Tom Tromey's message of "Sat, 11 Feb 2017 08:27:04 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129245 Archived-At: > I'm making the change, but I think the fix has to look like this: > (when (and (looking-at js--syntax-propertize-regexp-regexp) > ;; Don't touch text after END. > (<= (match-end 1) end)) > (put-text-property (match-beginning 1) (match-end 1) > 'syntax-table (string-to-syntax "\"/")) > (goto-char (match-end 0)))))) > ... the reason being, in the new regexp match #1 is just the terminating > "/", which is the only character whose syntax we want to modify here. Ah, I had misunderstood the code. Then yes. Stefan