From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters Date: Wed, 26 Jun 2019 10:33:00 -0400 Message-ID: References: <87zho2cd4f.fsf@gmail.com> <87wohvf22u.fsf@gmail.com> <87h88cvpkj.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="214853"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35564@debbugs.gnu.org, Noam Postavsky To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 16:34:52 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg90c-000tiS-Sf for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 16:34:50 +0200 Original-Received: from localhost ([::1]:40688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg90b-00035V-TF for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 10:34:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57307) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg901-0002uG-3b for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:34:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hg8zt-00073U-8w for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:34:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51360) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hg8zr-00071h-Tr for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:34:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hg8zq-00078L-HA for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:34:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.156155959227349 (code B ref 35564); Wed, 26 Jun 2019 14:34:02 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 26 Jun 2019 14:33:12 +0000 Original-Received: from localhost ([127.0.0.1]:36671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg8z1-000773-Mk for submit@debbugs.gnu.org; Wed, 26 Jun 2019 10:33:11 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg8yy-00076o-KZ for 35564@debbugs.gnu.org; Wed, 26 Jun 2019 10:33:09 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0B4F18116F; Wed, 26 Jun 2019 10:33:03 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AE9EE8030C; Wed, 26 Jun 2019 10:33:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1561559581; bh=VQbDHxafwJLHY580z5m3tNFLHlf2mOLflMoQX1s3cKE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Z2LGVnlL8Jr3RG79PjgnJUL4/O4lo224DA6gpy+twpHWLMeyIN/5/jNdKRZptOcQ7 yER8BLW7MC+R9urQ6xCsS+uPdZk1hgGJnkHED71Zp8STuT98C5TXHM5Uqg3W2uwao+ jW8TtAxLhNq1SepUTaLISSAB+FEIUoNa1KZYoWU3dhB+1qE5Ry4hNoEGz0vjA6YHXX cPf8GEFEJyO670STT4uGTGHH7HQez5PEB7hPi8F6yVav2ZOqwdjXbSVP6gCxVWMIhI Bjz5LgY6JgTr0Cmdit/Bh163O/X2My7/42wvSeeXCMywGpDBSmfNEevZxemj7GghY5 9G49befgQpK5A== Original-Received: from pastel (76-10-151-214.dsl.teksavvy.com [76.10.151.214]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7E5B31204BB; Wed, 26 Jun 2019 10:33:01 -0400 (EDT) In-Reply-To: <87h88cvpkj.fsf_-_@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Wed, 26 Jun 2019 08:16:44 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161499 Archived-At: I wouldn't bother with the read--propertize-prompt auxiliary function, but ... LGTM (including the use of a hardcoded face ;-) Stefan K=C3=A9vin Le Gouguec writes: > And here is the third set of patches. > > > > > The first patch is unchanged (it adjusts y-or-n-p so that the prompt's > text properties are preserved), the second patch uses the new > (literal=C2=A0=E2=80=A6) feature from rx and adds a test case for > dired--isolated-char-p[1]. > > Quoting my previous email: > >> Some things I wonder about: >>=20 >> 1. About read--propertize-prompt=E2=80=A6 >>=20 >> 1. Should the function return a copy of its argument instead of >> propertizing it directly? >>=20 >> 2. Is it properly named? Does it fit in subr.el? I placed it there >> because I figured other users of read-char in subr.el could use >> it, e.g. read-char-choice. >>=20 >> 2. dired-aux.el already contains some logic to detect isolated >> characters; I could not think of a way to re-use it, so I added my >> own functions to find *non*-isolated characters. I added unit tests >> for these new functions; still, there may be some redundancy there. > > Thank you for your time. > > > [1] (should-not (dired--isolated-char-p "foo `bar`?" 9))