unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 11339@debbugs.gnu.org, stephen.berman@gmx.net, stefan@marxist.se
Subject: bug#11339: 24.1.50; read-{buffer,file-name}-completion-ignore-case fails on non-ascii
Date: Thu, 07 Nov 2019 11:27:50 -0500	[thread overview]
Message-ID: <jwvmud74pxw.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83tv7fekkf.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Nov 2019 18:08:00 +0200")

>> I think the core of the bug is reproduced below:
>> 
>>     M-: (let ((completion-ignore-case t)) (try-completion "bah" '("bah" "bAh")))
>> 
>> this returns t instead of returning "bah".
>> Probably an error in the handling of `matchcount` in `try-completion`.
>
> Are you sure?

I think so, yes.

> I think the return value of t is expected, per these
> comments in try-completion:

I don't think so:

> 		  /* If this is an exact match except for case,
> 		     use it as the best match rather than one that is not an
> 		     exact match.  This way, we get the case pattern
> 		     of the actual match.  */

This says that (try-completion "bah" '("bAh" "bahfoo")) should return "bAh"

> 		      /* If there is more than one exact match ignoring case,
> 			 and one of them is exact including case,
> 			 prefer that one.  */

This says (try-completion "bah" '("bah" "bAh")) should return "bah" rather
than "bAh", which also agrees with I said above (it should not return t).

> 		      /* If there is no exact match ignoring case,
> 			 prefer a match that does not change the case
> 			 of the input.  */

This says that (try-completion "bah" '("bAhbar" "bahfoo")) should return
"bah" rather than "bAh".


        Stefan






  reply	other threads:[~2019-11-07 16:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25 15:37 bug#11339: 24.1.50; read-{buffer,file-name}-completion-ignore-case fails on non-ascii Stephen Berman
2013-07-08 22:08 ` Stephen Berman
2019-11-01 19:57 ` Stefan Kangas
2019-11-01 20:20   ` Eli Zaretskii
2019-11-01 22:37     ` Stephen Berman
2019-11-02  7:11       ` Eli Zaretskii
2019-11-02 15:09         ` Stephen Berman
2019-11-03 16:16           ` Eli Zaretskii
2019-11-04 13:39             ` Stephen Berman
2019-11-04 16:21               ` Eli Zaretskii
2019-11-04 16:22               ` Stephen Berman
2019-11-04 17:12                 ` Eli Zaretskii
2019-11-04 18:02                   ` Stephen Berman
2019-11-06 16:58                     ` Eli Zaretskii
2019-11-07 14:34                       ` Stephen Berman
2019-11-07 14:49                         ` Eli Zaretskii
2019-11-07 16:01                         ` Stefan Monnier
2019-11-07 16:08                           ` Eli Zaretskii
2019-11-07 16:27                             ` Stefan Monnier [this message]
2019-11-07 18:12                               ` Eli Zaretskii
2019-11-08 22:36                                 ` Stefan Monnier
2019-11-09  9:20                                   ` Eli Zaretskii
2019-11-09 17:56                                     ` Stephen Berman
2019-11-09 18:24                                     ` Stefan Monnier
2019-11-09 19:57                                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmud74pxw.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=11339@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=stefan@marxist.se \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).