From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed Date: Sun, 15 Dec 2019 15:33:30 -0500 Message-ID: References: <87o8wnj4nf.fsf@gmail.com> <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="98869"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38492@debbugs.gnu.org, kevin.legouguec@gmail.com To: dancol@dancol.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 15 21:34:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1igaal-000Pah-GW for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Dec 2019 21:34:15 +0100 Original-Received: from localhost ([::1]:42688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igaaj-0002w6-RF for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Dec 2019 15:34:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50121) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igaab-0002w0-MC for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 15:34:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igaaZ-00047j-SP for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 15:34:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igaaY-000460-2b for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 15:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1igaaY-0005dL-00 for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 15:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Dec 2019 20:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38492 X-GNU-PR-Package: emacs Original-Received: via spool by 38492-submit@debbugs.gnu.org id=B38492.157644202021360 (code B ref 38492); Sun, 15 Dec 2019 20:34:01 +0000 Original-Received: (at 38492) by debbugs.gnu.org; 15 Dec 2019 20:33:40 +0000 Original-Received: from localhost ([127.0.0.1]:37239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igaaC-0005YP-3P for submit@debbugs.gnu.org; Sun, 15 Dec 2019 15:33:40 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igaaA-0005Wz-W0 for 38492@debbugs.gnu.org; Sun, 15 Dec 2019 15:33:39 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 88EF580B9B; Sun, 15 Dec 2019 15:33:33 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F28E7810B1; Sun, 15 Dec 2019 15:33:31 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1576442012; bh=v9T+Ztk1QbqrBflTXbKpW0KKq8LVAhCCAbdBxvmUHJc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gsSMSWCyFPPF8kXetEQNdpCxfqZ1brGa/RebldTNyvtDdq2o1SAkMMNlXmu1N/6Du 6gbnVtAoWDIgOzpxkDeni1T91SkEAae2TZ9bdFMWpFhPYeasRPbH1D6dJmsHUTMyc+ akX2CyfzAZUZNAXSBGa4VYXbBG+0NYJHOQXr1VQ1qUiEcTXMSeF4tuJJsjMvu3h+QO JpPPoZXmLSWZAdTOGebtCL6QjfPz22QR9TbLZ1+fif02J6jHuLMxhGLPoOXsFxJJcz DO2RdpMXHQ92ZfBYe3NMiT/WftXs/zTlPW56vw4WHdIoJ4WTPaFLllnJlS9rI6KCJs +53/HYVkpE+CA== Original-Received: from pastel (unknown [45.72.153.183]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BB03512120D; Sun, 15 Dec 2019 15:33:31 -0500 (EST) In-Reply-To: <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> (dancol@dancol.org's message of "Fri, 06 Dec 2019 11:02:28 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173393 Archived-At: >> > We should probably consider just removing the pure space mechanism at >> > some point. >> Does this mean you agree with removing the warning in startup.el >> about overflowed pure space? > Yes. Why? This warning was placed because we needed to disable GC in dumps that had overflown the purespace, so the dumped Emacs was not fully functional. I see that with the current pdump we don't disable GC in dumps that overflew the purespace. Why is that? IIRC, the problem with running GC in an Emacs with overflown purespace is that overflowing the purespace created pointers from the purespace to the heap and those aren't traced by the GC so it resulted in core dumps. I can't exactly remember the cases where this happened, but I can't see why the pdumper would be less affected than the unexec code. I see that the code has a slightly different explanation: /* Can't GC if pure storage overflowed because we can't determine if something is a pure object or not. */ garbage_collection_inhibited++; but that comment similarly seems to apply to pdump just as much as it applies to unexec. Stefan