From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#39057: 27.0.60; copy-file interactive VS from lisp disagreement Date: Wed, 15 Jan 2020 15:35:37 -0500 Message-ID: References: <87eew8z6js.fsf@calancha-pc.dy.bbexcite.jp> <837e1zagqh.fsf@gnu.org> <83wo9z8lt9.fsf@gnu.org> <83v9pj8koa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="102734"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: tino.calancha@gmail.com, 39057@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 15 21:36:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irpOn-000QYx-RM for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 21:36:21 +0100 Original-Received: from localhost ([::1]:60404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irpOm-0007Jt-HM for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 15:36:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45900) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irpOY-0007Jf-6g for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 15:36:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irpOU-0002Nh-6L for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 15:36:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57940) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1irpOU-0002NY-34 for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 15:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1irpOU-0003AG-0u for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 15:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jan 2020 20:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39057 X-GNU-PR-Package: emacs Original-Received: via spool by 39057-submit@debbugs.gnu.org id=B39057.157912055512151 (code B ref 39057); Wed, 15 Jan 2020 20:36:01 +0000 Original-Received: (at 39057) by debbugs.gnu.org; 15 Jan 2020 20:35:55 +0000 Original-Received: from localhost ([127.0.0.1]:35680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irpOJ-00039p-Lg for submit@debbugs.gnu.org; Wed, 15 Jan 2020 15:35:55 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irpOE-00039V-Bi for 39057@debbugs.gnu.org; Wed, 15 Jan 2020 15:35:50 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EC6DB44DE52; Wed, 15 Jan 2020 15:35:40 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4B8A844DE2E; Wed, 15 Jan 2020 15:35:39 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1579120539; bh=y1b0AN8fgPlF12kFPANe5Q+KZilUIlslvxe2KgAMV3w=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZLVFbDYVA+S7vjHCXHFbIiXJd2DWV2ML5xWRF7lohRYtqyz4P38xYPvwxmG6XyGFT 5D1CxnEYuVVPBVXrPFGFR4o0urGLo1iKgGGVEEdjMcR89RofPbMkRx7PDGqnc6Z4tf NHrUvavGtlg8OydzVSFA5Dj7zXdaulgZra0zjWZ5icDH/+VGlhpQ7iCXmX0C7v7JIP HLgVMjfllrp9h+TMYZj+1KLYh2apPCmRK1yEK5KxdttXl7qMwpYWSyv6mnNs8YupoU POvjHiWxwUOZsJ0FvAgbbJvm3KW9rqhbdxiO28LJp7BdVXL+CW8/HMMmpsmbZ4XFhZ In+RLQzWgYUBw== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 110671203C3; Wed, 15 Jan 2020 15:35:39 -0500 (EST) In-Reply-To: <83v9pj8koa.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Jan 2020 16:12:37 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174669 Archived-At: > Answering myself: this is a problem with completion routines: when the > user types a file name that is exactly identical to the default (or > just presses RET, which is the same), then the completion code in > read-file-name-internal returns a value that has the trailing slash > stripped. And we now require a trailing slash to recognize NEWNAME as > a directory. The problem seems to be linked to the value "" passed as `initial` to `read-file-name`, it doesn't show up with a nil value for `initial`. It seems to come from the following lines at the beginning of read-file-name-default: (unless default-filename (setq default-filename (if initial (expand-file-name initial dir) buffer-file-name))) because: M-: (expand-file-name "" "/tmp/") => "/tmp" `copy-file` uses a "" argument via the `G` interactive code: case 'F': /* Possibly nonexistent file name. */ args[i] = read_file_name (Qnil, Qnil, Qnil, Qnil); break; case 'G': /* Possibly nonexistent file name, default to directory alone. */ args[i] = read_file_name (Qnil, Qnil, empty_unibyte_string, Qnil); break; IOW it uses `G` since otherwise hitting just RET would return the `buffer-file-name` rather than the `default-directory`. I propose the patch below. Stefan diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 4a33d61afc..e12f7b1156 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -3027,8 +3027,13 @@ read-file-name-default (unless dir (setq dir (or default-directory "~/"))) (unless (file-name-absolute-p dir) (setq dir (expand-file-name dir))) (unless default-filename - (setq default-filename (if initial (expand-file-name initial dir) - buffer-file-name))) + (setq default-filename + (cond + ((null initial) buffer-file-name) + ;; Special-case "" because (expand-file-name "" "/tmp/") returns + ;; "/tmp" rather than "/tmp/" (bug#39057). + ((equal "" initial) dir) + (t (expand-file-name initial dir))))) ;; If dir starts with user's homedir, change that to ~. (setq dir (abbreviate-file-name dir)) ;; Likewise for default-filename.