From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@linkov.net>
Cc: 46268@debbugs.gnu.org
Subject: bug#46268: 27.1.91; Error in occur-rename-buffer
Date: Wed, 03 Feb 2021 10:38:45 -0500 [thread overview]
Message-ID: <jwvmtwli2ov.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwva6sljjdn.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 03 Feb 2021 10:05:43 -0500")
> AFAICT, `occur--garbage-collect-revert-args` aims to throw away the
> overlays when they're not needed, but we will need them again if we want
> to `revert-buffer`, so we shouldn't call this function until we're sure
> `revert-buffer` won't be called. IOW, I think we should just remove
> the above call.
I now see what's going on: this call is supposed to throw away the
overlay used by the previous invocation of `occur`. So when we revert,
we don't want to throw them away but when it's a fresh new invocation,
we do.
Maybe we should add a (unless (eq bufs (nth 2 occur-revert-arguments)))?
Stefan
next prev parent reply other threads:[~2021-02-03 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 8:54 bug#46268: 27.1.91; Error in occur-rename-buffer Juri Linkov
2021-02-03 15:05 ` Stefan Monnier
2021-02-03 15:38 ` Stefan Monnier [this message]
2021-02-03 17:34 ` Juri Linkov
2021-02-03 15:22 ` Stefan Monnier
2021-02-03 17:36 ` Juri Linkov
2021-02-03 19:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmtwli2ov.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=46268@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).