unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 55355@debbugs.gnu.org, Ivan Sokolov <ivan-p-sokolov@ya.ru>
Subject: bug#55355: TBD: inappropriate inlining, cmacro errors
Date: Wed, 11 May 2022 16:22:23 -0400	[thread overview]
Message-ID: <jwvmtfnn7s0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87a6bob77f.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 11 May 2022 14:10:44 +0200")

>> (cl-defstruct (foo (:constructor foo<-list ((bar _ baz))))
>>   bar
>>   baz)
[...]
> Perhaps Stefan has some comments; added to the CCs.

Looks like another bug in `cl-defsubst`.

To the extent that I dislike this "destructuring args" in function
signatures, I'd recommend "if it hurts, don't do that".

You can probably work around the problem using the `:noinline` feature
added recently to `cl-defstruct`.  As for a fix, it's probably a small
matter of making `cl-defsubst` give up on inlining when the formal
arglist is "too complex".


        Stefan






      parent reply	other threads:[~2022-05-11 20:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 22:57 bug#55355: TBD: inappropriate inlining, cmacro errors Ivan Sokolov
2022-05-11 12:10 ` Lars Ingebrigtsen
2022-05-11 18:20   ` Ivan Sokolov
2022-05-11 18:42     ` Eli Zaretskii
2022-05-11 20:22   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmtfnn7s0.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=55355@debbugs.gnu.org \
    --cc=ivan-p-sokolov@ya.ru \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).