From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Arash Esbati <arash@gnu.org>, 58329@debbugs.gnu.org
Subject: bug#58329: 29.0.50; [PATCH] Pass correct environment name to `reftex-label'
Date: Thu, 06 Oct 2022 09:41:32 -0400 [thread overview]
Message-ID: <jwvmta9oyt9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87leptywje.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 06 Oct 2022 14:19:17 +0200")
Lars Ingebrigtsen [2022-10-06 14:19:17] wrote:
> Arash Esbati <arash@gnu.org> writes:
>
>> - '(if (and (boundp 'reftex-mode) reftex-mode) (reftex-label "table"))))
>> + '(if (and (boundp 'reftex-mode) reftex-mode) (reftex-label "figure"))))
>
> Your change look like the right thing to me. This code was apparently
> introduced in:
>
> commit dd166d5fa1712b0dda35859c91d89666c2873471
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> AuthorDate: Sun Oct 3 19:53:23 2004 +0000
>
> It looks to me like a cut and paste error -- I've added Stefan to the
> CCs; I'm sure he remembers this code. It's just 18 years ago.
Oh, so that's what it was. I've noticed the problem but just lived with
the quirk thinking it was a problem in my own local changes since noone
else complained.
Thanks a lot Arash for fixing it!
Stefan
next prev parent reply other threads:[~2022-10-06 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 8:59 bug#58329: 29.0.50; [PATCH] Pass correct environment name to `reftex-label' Arash Esbati
2022-10-06 12:19 ` Lars Ingebrigtsen
2022-10-06 13:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-10-06 18:01 ` Arash Esbati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmta9oyt9.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=58329@debbugs.gnu.org \
--cc=arash@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).