From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs,gmane.emacs.devel Subject: bug#60974: 30.0.50; byte-compile-preprocess mutates self evaluating forms in expanded macro bodies Date: Sat, 28 Jan 2023 18:10:59 -0500 Message-ID: References: <6eb5f27bf591c3d52766d8b9da46e7301f2ff0ab.camel@gmail.com> <5ccd0d1f9f64a5fd20e5403a07b06d6074b6c8f6.camel@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8923"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 60974@debbugs.gnu.org, emacs-devel To: Vibhav Pant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 29 00:12:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLuMo-00027j-HV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Jan 2023 00:12:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLuMe-0000qj-8g; Sat, 28 Jan 2023 18:12:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLuMd-0000qY-6j for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 18:12:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLuMc-0000wO-Pm for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 18:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLuMc-0004o1-77 for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 18:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2023 23:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60974 X-GNU-PR-Package: emacs Original-Received: via spool by 60974-submit@debbugs.gnu.org id=B60974.167494749918439 (code B ref 60974); Sat, 28 Jan 2023 23:12:02 +0000 Original-Received: (at 60974) by debbugs.gnu.org; 28 Jan 2023 23:11:39 +0000 Original-Received: from localhost ([127.0.0.1]:41737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLuME-0004nL-PO for submit@debbugs.gnu.org; Sat, 28 Jan 2023 18:11:39 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLuMC-0004n6-12 for 60974@debbugs.gnu.org; Sat, 28 Jan 2023 18:11:37 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 78DE11000C9; Sat, 28 Jan 2023 18:11:29 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 11B1C10000D; Sat, 28 Jan 2023 18:11:28 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1674947488; bh=2dGVAuPfBvGLs/XLJbuZW17VuPAhdZUmNxpgLuhJKl8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eR0Pm7bV1CPXiBn1CeJCzZiP2PttIhLOntc0qN/qAJJ3P1JM+1VqCXbuHQ/utL093 PA9MiukZsgtas6TeHfHRTrIU4zdZZQdFkO2XqjoRdp9HrKu1Q/1MaPN5U3JnPtozLJ sOTaBAaTmwS12Ouvn/d+1RHiC8RsDxiRuBQX6Cc6AdFjzPY5MhaGamJoySg0Vp9qzZ qTCKZ9CULp0T6SzlA30ID0YdlU312XKXIvSyFRqR0DAiLbsuxzNzIetCokAShrIPgb JSg0Hu1WPzIvvGhrS4s3gpjAKC9abFSxs3YBdtNA/RRDY3SNbAByUrUiB49idIFgBc 4sfnxMb/yZKSw== Original-Received: from ceviche (unknown [207.162.20.112]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C3FE8123029; Sat, 28 Jan 2023 18:11:27 -0500 (EST) In-Reply-To: <5ccd0d1f9f64a5fd20e5403a07b06d6074b6c8f6.camel@gmail.com> (Vibhav Pant's message of "Fri, 27 Jan 2023 18:14:39 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254322 gmane.emacs.devel:302732 Archived-At: > Ah, right. Theother way I could think of a fix is setq-ing `form` to a > shallow copy of the original form, with only the place(s) changed. This > patch tries to do that by using `pcase-let` to destructure forms. Hmm... yes, that's closer. It's pretty ugly, tho. Yet it's hard to make it less ugly here because the `cconv-freevars-alist` really depends on `eq` equality. Maybe we should pass `cif` to `cconv--convert-function` (or maybe even move most of that `cconv--interactive-form-funs`-handling to that function) and arrange for that function to do the "non-side-effecting-equivalent-of" (setf (cadr (car bf)) form)? Stefan