From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path Date: Sat, 03 Jun 2023 10:06:05 -0400 Message-ID: References: <83y1l7gzqw.fsf@gnu.org> <87ilcb2p1l.fsf@posteo.net> <87sfb8g85v.fsf@posteo.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18686"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 63757@debbugs.gnu.org, =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8=D0=B9_?= =?UTF-8?Q?=D0=91=D0=BE=D0=B9=D0=BA=D0=BE=D0=B2?= To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 03 16:07:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5Ruk-0004do-77 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jun 2023 16:07:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5RuL-0004Jo-89; Sat, 03 Jun 2023 10:07:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5RuI-0004HX-CU for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 10:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5RuI-0005at-3z for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 10:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5RuH-00047w-Tq for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 10:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Jun 2023 14:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63757 X-GNU-PR-Package: emacs Original-Received: via spool by 63757-submit@debbugs.gnu.org id=B63757.168580117715776 (code B ref 63757); Sat, 03 Jun 2023 14:07:01 +0000 Original-Received: (at 63757) by debbugs.gnu.org; 3 Jun 2023 14:06:17 +0000 Original-Received: from localhost ([127.0.0.1]:44031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5RtZ-00046O-2x for submit@debbugs.gnu.org; Sat, 03 Jun 2023 10:06:17 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5RtV-00045x-SK for 63757@debbugs.gnu.org; Sat, 03 Jun 2023 10:06:14 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6A6CC441538; Sat, 3 Jun 2023 10:06:08 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 11C9D4410B0; Sat, 3 Jun 2023 10:06:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1685801167; bh=RwHo1TfU5aoRnpF9TdJiGdUfwfZyDdDuTq362oVXcak=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ohP/QblqWNBlubR51jGVU909R1S/JGVAL6zvRrGbaRjJrOQLcHx0xp30nH6/6vQSC 8S6lIuLjn/bcjpK14ffMmZ73E4ZavbtzwlzNfBc2njgBkFAZECvXv7SlqUk3iPV7I/ zJJs/MQ2d4iecOrPWXYTOqnxgs+GXgMIyJjwNTQkQt1IW1QMzs1OIBKzFfP+Z/hPV3 wtwa+LdffUiNcv14BcqhDLXYojxOUu7OaaD98+Nl482V3jJqGkngvWjdMsEyBr7SZ3 C16x0pRwEU7KGT8w7r1C5Qu+nUyS8BNmKwIvdWBpHMjK8YzcIx1Bb4jcCQvv/IdwoT pnuoZ3MPIht9Q== Original-Received: from pastel (76-10-180-239.dsl.teksavvy.com [76.10.180.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C086D12026C; Sat, 3 Jun 2023 10:06:06 -0400 (EDT) In-Reply-To: <87sfb8g85v.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 03 Jun 2023 10:19:24 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262846 Archived-At: >> Won't this work: >> >> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >> index 01826da273d..7eb185e7042 100644 >> --- a/lisp/emacs-lisp/package.el >> +++ b/lisp/emacs-lisp/package.el >> @@ -927,7 +927,9 @@ package--get-activatable-pkg >> (package-vc-p p2) >> ;; Prefer builtin packages. >> (package-disabled-p p1 v1) >> - (not (package-disabled-p p2 v2)))))))) >> + (not (package-disabled-p p2 v2)) >> + ;; Prever newer packages >> + (version-list-< v2 v1))))))) >> ;; Check if PACKAGE is available in `package-alist'. >> (while >> (when pkg-descs > > Ping? The packages should already be sorted by version in `package-alist`, so at best this will paper over the problem. This said, the `sort` call's predicate looks weird indeed: (lambda (p1 p2) (let ((v1 (package-desc-version p1)) (v2 (package-desc-version p2))) (or ;; Prefer VC packages. (package-vc-p p1) (package-vc-p p2) ;; Prefer builtin packages. (package-disabled-p p1 v1) (not (package-disabled-p p2 v2)))))))) - If both p1 and p2 are VC, then it will return non-nil, so they're both "strictly less than" the other :-( - If neither is VC nor disabled, we return non-nil, which again means they're both "strictly less than" the other. - The comment says "Prefer builtin packages" but the code checks `package-disabled-p`. And now that I look more carefully, maybe this `sort` is the culprit after all, because it operates directly on the list contained in `packages-alist`, modifying it in-place :-( I think we should *not* sort here: we should instead sort when we populate `package-alist` (like we already do). So the "Prefer VC" part of the sorting should be moved to `package-process-define-package` (and the `package-disabled-p` can be dropped because it's already taken care of by the loop that follows the above code). Stefan