From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function Date: Mon, 07 Aug 2023 22:44:29 -0400 Message-ID: References: <8B08E514-B2D5-48F5-BA90-4F5A9492F8F9@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18806"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 65017@debbugs.gnu.org, Eric Marsden To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 08 04:45:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTCit-0004cP-GF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Aug 2023 04:45:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTCid-0005oo-7U; Mon, 07 Aug 2023 22:45:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTCiW-0005hX-0V for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 22:45:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTCiT-0007HW-Rp for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 22:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTCiT-00028P-NG for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 22:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Aug 2023 02:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65017 X-GNU-PR-Package: emacs Original-Received: via spool by 65017-submit@debbugs.gnu.org id=B65017.16914626928172 (code B ref 65017); Tue, 08 Aug 2023 02:45:01 +0000 Original-Received: (at 65017) by debbugs.gnu.org; 8 Aug 2023 02:44:52 +0000 Original-Received: from localhost ([127.0.0.1]:34639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTCiJ-00027k-Pg for submit@debbugs.gnu.org; Mon, 07 Aug 2023 22:44:52 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTCiI-00027Y-Fg for 65017@debbugs.gnu.org; Mon, 07 Aug 2023 22:44:51 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A2C1C444AC6; Mon, 7 Aug 2023 22:44:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1691462683; bh=W2qkgMyTWYLtqBr146S8I+38Sin7rbOI61nt4pUJhLo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WUAJvUAkSMGlOVfMKd5sspBXlNTnN4Cv20qd8TJmm98hkY4pGUc3qyVNuInjZPb7q Vj/HBPMqbD/ciBXSCW2b/FEQUUX0mvT8xaExll4+6vKbeLOIIhsI5/y+UtI7VRdJvO tQDb4u3whhNWAnYyr9/ZDwy+8Dv1KyLsL82NKyNFuAJ2m6oLWKN9ZGAnBoWhrQ8zfG fo08SVFcdY/jiDL8Eg6TESEBBZodeEL1KOkfMxpKSYzFDs8o7FlDvzh17iZTaW0CbK E2bOg1vPpy0cYOBopjx/BXjF9R76ETvCZIbwQXsNM2vUSjfEdwO6i0hEL+2/ZSI4oF TMXkgs6/Z+a1g== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4A1D9444AC8; Mon, 7 Aug 2023 22:44:43 -0400 (EDT) Original-Received: from alfajor (host56.201-252-107.telecom.net.ar [201.252.107.56]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 015FE1202BD; Mon, 7 Aug 2023 22:44:41 -0400 (EDT) In-Reply-To: (Alan Mackenzie's message of "Sun, 6 Aug 2023 11:59:36 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266913 Archived-At: > I suggest installing this patch into master. LGTM, thanks. >> > Stefan, it would still be nice for cl--labels-convert-cache to get >> > initialised each time it gets used. >> No, the problem is not initialization, as I pointed out. The problem is >> that this `eq` should not consider a symbol equal to a sympos *ever* >> (contrary to most other uses of `eq` in macros). > > Are you sure? Yes. > Why not? Not sure how to explain it any further than what I already described. > If cl--labels-convert-cache is being used > inside the byte compiler, it surely needs to consider # 42> and # as eq? No, it should not treat them equal (when it does, it introduces an incorrect sympos and can thus lead to error messages pointing at the wrong place). > There is no mechanism to make these two SWPs eq whilst excluding their > eq with the bare symbol. We luckily don't need such a mechanism here: we just need to use "BASE_EQ" :-) Stefan