From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andrea Corallo <acorallo@gnu.org>, 67141@debbugs.gnu.org
Subject: bug#67141: 30.0.50; Missing element in the backtrace
Date: Mon, 20 Nov 2023 08:41:51 -0500 [thread overview]
Message-ID: <jwvmsv8czt0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <834jhgk4hv.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Nov 2023 14:12:44 +0200")
>> With ea7a52dbaed I added eval to 'native-comp-never-optimize-functions'
>> so this should fix the reported issue,
Thanks.
>> for mapcar I think we should prove it has really no performance
>> impact before deciding to include it as well.
Agreed. It occurred to me that there are several places where we use
`mapcar` with a lists that's usually empty, and hence where the funcall
overhead is not necessarily negligible.
> Should this bug be closed now?
AFAIK the sample backtrace is only one among many others and the fact
that the missing element in the backtrace happened to be using `eval` is
circumstantial, so the addition of `eval` to
`native-comp-never-optimize-functions` just circumvents the problem for
`eval` but not for all the other C primitives we call directly.
IOW no, I don't think it fixes the bug :-(
Stefan
next prev parent reply other threads:[~2023-11-20 13:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 22:29 bug#67141: 30.0.50; Missing element in the backtrace Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-13 14:03 ` Eli Zaretskii
2023-11-13 16:27 ` Andrea Corallo
2023-11-16 9:35 ` Andrea Corallo
2023-11-17 19:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-17 20:48 ` Andrea Corallo
2023-11-17 21:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 8:55 ` Andrea Corallo
2023-11-20 12:12 ` Eli Zaretskii
2023-11-20 13:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-11-20 15:13 ` Andrea Corallo
2023-11-20 17:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 18:16 ` Andrea Corallo
2023-11-20 18:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 21:01 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmsv8czt0.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=67141@debbugs.gnu.org \
--cc=acorallo@gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).