From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Thu, 14 Dec 2023 14:36:55 -0500 Message-ID: References: <878r919qfh.fsf@localhost> <87y1dzvvf0.fsf@localhost> <83plzas3pg.fsf@gnu.org> <87r0jqw8u9.fsf@localhost> <83jzpis08a.fsf@gnu.org> <87il52w744.fsf@localhost> <83fs06rz10.fsf@gnu.org> <87fs06w4ui.fsf@localhost> <83bkaurut9.fsf@gnu.org> <87o7esq319.fsf@localhost> <83bkasrb3f.fsf@gnu.org> <83wmtgpuyf.fsf@gnu.org> <871qboprh3.fsf@localhost> <87y1dwobey.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24981"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dmitry@gutov.dev, Eli Zaretskii , mattias.engdegard@gmail.com, 66117@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 14 20:38:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDrXE-0006Hz-F6 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Dec 2023 20:38:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDrX3-0001bu-8L; Thu, 14 Dec 2023 14:38:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDrX1-0001bj-Cx for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2023 14:38:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rDrX1-0006gi-4X for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2023 14:38:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rDrX0-0003gQ-4n for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2023 14:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Dec 2023 19:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.170258262414074 (code B ref 66117); Thu, 14 Dec 2023 19:38:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 14 Dec 2023 19:37:04 +0000 Original-Received: from localhost ([127.0.0.1]:50949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDrW4-0003ew-9C for submit@debbugs.gnu.org; Thu, 14 Dec 2023 14:37:04 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDrW2-0003eO-LK for 66117@debbugs.gnu.org; Thu, 14 Dec 2023 14:37:03 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AB5764419A7; Thu, 14 Dec 2023 14:36:57 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1702582616; bh=+lu/xrX1KXmTukwawKMypbE/iWrgDWOW1+7rpg3PYuI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Cab2kwAwUv2Qt/e1O5i+BnAGwFjCa115P0239pNv03VmjGUhAW8kf4iWWAYiCGk+B oU88qSNHAvTOBC9w2yu50CgNttb/bt5Gl3Fbn0O51QxzrgwKFH28H9hnFcgmzr0vWW H3936bF2hQON0zkdg0N+bLrCeuMDTrKrsK3TfW1skuxlHQ0802ZBIGLTSiCCBNFQNW 2Ay4I0SsXXWx8ez0OfujUc2kMphsP/Ehn21JJ8UzJRHujAgTN6tW/G1pbOcdbtU9JB Fs9nrnxZlyj/iiuwWH+T/qT+qZEUUH/jHDP3NFoOj3u960HdYeKYR5Si2BErqvL9GC HhCeH2FZXthuw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1BA8B4418ED; Thu, 14 Dec 2023 14:36:56 -0500 (EST) Original-Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D0594120397; Thu, 14 Dec 2023 14:36:55 -0500 (EST) In-Reply-To: <87y1dwobey.fsf@localhost> (Ihor Radchenko's message of "Thu, 14 Dec 2023 19:02:13 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276212 Archived-At: >>>>> It won't be buffer-local-if-changed, so binding it will not be costly. >>>> As mentioned elsewhere in this bug-report we can make `case-fold-search` >>>> into a `DEFVAR_LISP`: it would have no visible impact to ELisp and would >>>> avoid the costly let-bindings. >>> Wouldn't DEFVAR_LISP break major modes that do (setq case-fold-search ...)? >> >> No, it makes no difference to Lisp. It only changes the implementation >> strategy: DEFVAR_LISP stores the value in a global C variable (which >> thus requires more processing when the var is buffer-local, more >> specifically updating the C var when we `set-buffer`), whereas >> DEFVAR_PER_BUFFER stores the value inside the buffer object (which >> thus requires more processing when the var is *not* buffer-local since >> the global value is duplicated in all the buffers where it's not made >> buffer-local). > > Do I understand correctly that what is needed to implement your > suggestion is > > 1. Remove case_fold_search_ slot from buffer objects > 2. Use DEFVAR_LISP for case-fold-search > 3. Declare case-fold-search buffer-local > 4. Replace BVAR(...) references in C with Vcase_fold_search Yes (assuming that 3 refers to the use of `make-variable-buffer-local`). Stefan