bug#3209: 23.0.92; vc-delete-file is not autoloaded

bug#3209: 23.0.92; vc-delete-file is not autoloaded

[Bob Rogers]

   If I do "emacs -Q vc-controlled-file", I then find that I can't do
"M-x vc-delete-file" immediately, because this command is undefined.
It's in vc.el, and the mode line shows that Emacs knows the file is
under version control, so I assume that vc.el must not be loaded as a
side-effect of finding a version-controlled file.  So shouldn't
vc-delete-file be autoloaded in that case?  (And possibly other commands
in vc.el?)

   Note that this *is* a regression wrt 22.3.

					-- Bob Rogers
					   http://www.rgrjr.com/

------------------------------------------------------------------------
In GNU Emacs 23.0.92.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2009-04-24 on rgr
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Text

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x C-f f o o <tab> <return> M-x v c - d e l e <tab> 
C-g M-x r e p o r <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading vc-svn...done
Quit

bug#3209: 23.0.92; vc-delete-file is not autoloaded

[Chong Yidong]

>    If I do "emacs -Q vc-controlled-file", I then find that I can't do
> "M-x vc-delete-file" immediately, because this command is undefined.
> It's in vc.el, and the mode line shows that Emacs knows the file is
> under version control, so I assume that vc.el must not be loaded as a
> side-effect of finding a version-controlled file.  So shouldn't
> vc-delete-file be autoloaded in that case?  (And possibly other
> commands in vc.el?)
>
>    Note that this *is* a regression wrt 22.3.

I think vc-create-repo, vc-register-with, and vc-delete-file should be
autoloaded.  Anyone on this list have any objection?

*** trunk/lisp/vc.el.~1.715.~	2009-03-21 11:52:16.000000000 -0400
--- trunk/lisp/vc.el	2009-05-04 21:27:35.000000000 -0400
***************
*** 1182,1187 ****
--- 1182,1188 ----
       (t
        (error "Fileset is in an unknown state %s" state)))))
  
+ ;;;###autoload
  (defun vc-create-repo (backend)
    "Create an empty repository in the current directory."
    (interactive
***************
*** 1258,1263 ****
--- 1259,1265 ----
             )
  	 (message "Registering %s... done" files))))))
  
+ ;;;###autoload
  (defun vc-register-with (backend)
    "Register the current file with a specified back end."
    (interactive "SBackend: ")
***************
*** 2138,2143 ****
--- 2140,2146 ----
  	      (throw 'found f)))
         (error "New file lacks a version control directory")))))
  
+ ;;;###autoload
  (defun vc-delete-file (file)
    "Delete file and mark it as such in the version control system."
    (interactive "fVC delete file: ")

bug#3209: 23.0.92; vc-delete-file is not autoloaded

[Stefan Monnier]

>    If I do "emacs -Q vc-controlled-file", I then find that I can't do
> "M-x vc-delete-file" immediately, because this command is undefined.
> It's in vc.el, and the mode line shows that Emacs knows the file is
> under version control, so I assume that vc.el must not be loaded as a
> side-effect of finding a version-controlled file.  So shouldn't
> vc-delete-file be autoloaded in that case?  (And possibly other commands
> in vc.el?)

Yes, it should be autoloaded, indeed.

>    Note that this *is* a regression wrt 22.3.

I don't think so.


        Stefan

bug#3209: marked as done (23.0.92; vc-delete-file is not autoloaded)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]


Your message dated Tue, 05 May 2009 00:03:15 -0400
with message-id <jwvfxfkmc2i.fsf-monnier+emacsbugreports@gnu.org>
and subject line Re: bug#3209: 23.0.92; vc-delete-file is not autoloaded
has caused the Emacs bug report #3209,
regarding 23.0.92; vc-delete-file is not autoloaded
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3209: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3209
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3911 bytes --]

From: Bob Rogers <rogers-emacs@rgrjr.dyndns.org>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.92; vc-delete-file is not autoloaded
Date: Mon, 4 May 2009 15:53:24 -0400
Message-ID: <18943.18356.482668.944474@rgr.rgrjr.com>

   If I do "emacs -Q vc-controlled-file", I then find that I can't do
"M-x vc-delete-file" immediately, because this command is undefined.
It's in vc.el, and the mode line shows that Emacs knows the file is
under version control, so I assume that vc.el must not be loaded as a
side-effect of finding a version-controlled file.  So shouldn't
vc-delete-file be autoloaded in that case?  (And possibly other commands
in vc.el?)

   Note that this *is* a regression wrt 22.3.

					-- Bob Rogers
					   http://www.rgrjr.com/

------------------------------------------------------------------------
In GNU Emacs 23.0.92.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2009-04-24 on rgr
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Text

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x C-f f o o <tab> <return> M-x v c - d e l e <tab> 
C-g M-x r e p o r <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading vc-svn...done
Quit



[-- Attachment #3: Type: message/rfc822, Size: 1806 bytes --]

From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Bob Rogers <rogers-emacs@rgrjr.dyndns.org>
Cc: 3209-done@emacsbugs.donarmstrong.com
Subject: Re: bug#3209: 23.0.92; vc-delete-file is not autoloaded
Date: Tue, 05 May 2009 00:03:15 -0400
Message-ID: <jwvfxfkmc2i.fsf-monnier+emacsbugreports@gnu.org>

> So shouldn't vc-delete-file be autoloaded in that case?

Yes, done,


        Stefan