From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#7941: 24.0.50; Compilation mode broken, next-error not working Date: Tue, 01 Feb 2011 11:35:26 -0500 Message-ID: References: <4D456E1F.1060204@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1296580339 20113 80.91.229.12 (1 Feb 2011 17:12:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 1 Feb 2011 17:12:19 +0000 (UTC) Cc: 7941-done@debbugs.gnu.org To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 01 18:12:15 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PkJls-0004cp-2I for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Feb 2011 18:12:10 +0100 Original-Received: from localhost ([127.0.0.1]:53772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkJlp-0000Nr-PO for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Feb 2011 12:12:01 -0500 Original-Received: from [140.186.70.92] (port=58268 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkJlZ-0007g1-4m for bug-gnu-emacs@gnu.org; Tue, 01 Feb 2011 12:11:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PkJfg-00032N-Jz for bug-gnu-emacs@gnu.org; Tue, 01 Feb 2011 12:05:45 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PkJfg-00032I-Fk for bug-gnu-emacs@gnu.org; Tue, 01 Feb 2011 12:05:40 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PkJ5F-0001aP-TS for bug-gnu-emacs@gnu.org; Tue, 01 Feb 2011 11:28:01 -0500 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Feb 2011 16:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 7941 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 7941@debbugs.gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by 7941-done@debbugs.gnu.org id=D7941.12965776266028 (code D ref 7941); Tue, 01 Feb 2011 16:28:01 +0000 Original-Received: (at 7941-done) by debbugs.gnu.org; 1 Feb 2011 16:27:06 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkJ4L-0001ZB-Pb for submit@debbugs.gnu.org; Tue, 01 Feb 2011 11:27:06 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkJ4K-0001Yh-79 for 7941-done@debbugs.gnu.org; Tue, 01 Feb 2011 11:27:04 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAE7ER01Ld/8K/2dsb2JhbAClBnS8WYVTBIUTjWiBfA X-IronPort-AV: E=Sophos;i="4.60,411,1291611600"; d="scan'208";a="90130702" Original-Received: from 75-119-255-10.dsl.teksavvy.com (HELO ceviche.home) ([75.119.255.10]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 01 Feb 2011 11:35:26 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 5A2F8660DC; Tue, 1 Feb 2011 11:35:26 -0500 (EST) In-Reply-To: <4D456E1F.1060204@swipnet.se> ("Jan =?UTF-8?Q?Dj=C3=A4rv?="'s message of "Sun, 30 Jan 2011 14:56:47 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 01 Feb 2011 11:28:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:43813 Archived-At: > (setq compilation-scroll-output t) > M-x compile (somewhere where you get warnings or errors). > M-x next-error > compilation-next-error-function: Wrong type argument: arrayp, nil Thanks, I just installed the patch below which should fix it. > M-x compile > run-hooks: Wrong type argument: number-or-marker-p, nil I believe I've fixed this one yesterday or so. > Can the "compilation--flush-parse: 1 16056" messages be turned off? No, of course not, they're crucial for the user. Stefan "just kidding" === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2011-02-01 10:12:25 +0000 +++ lisp/ChangeLog 2011-02-01 16:31:01 +0000 @@ -1,3 +1,8 @@ +2011-02-01 Stefan Monnier + + * progmodes/compile.el (compilation-next-error): Check there's + a message before using it (bug#7941). + 2011-02-01 Jay Belanger * calc/calc-mtx.el (math-lud-pivot-check): New function. @@ -6,8 +11,8 @@ 2011-01-31 Alan Mackenzie - * progmodes/cc-cmds.el (c-forward-over-illiterals): Continue - parsing if we encounter a naked # (Bug#7595). + * progmodes/cc-cmds.el (c-forward-over-illiterals): + Continue parsing if we encounter a naked # (Bug#7595). (c-beginning-of-statement): Avoid loop in locating the beginning of a macro. @@ -34,8 +39,8 @@ 2011-01-31 Kenichi Handa - * international/quail.el (quail-keyboard-layout-alist): Remove - superfluous SPC for "pc105-uk" (bug#7927). + * international/quail.el (quail-keyboard-layout-alist): + Remove superfluous SPC for "pc105-uk" (bug#7927). 2011-01-31 Glenn Morris === modified file 'lisp/progmodes/compile.el' --- lisp/progmodes/compile.el 2011-01-31 17:11:11 +0000 +++ lisp/progmodes/compile.el 2011-02-01 16:28:10 +0000 @@ -2140,7 +2140,7 @@ (or pt (setq pt (point))) (let* ((msg (get-text-property pt 'compilation-message)) ;; `loc', `msg', and `last' are used by the compilation-loop macro. - (loc (compilation--message->loc msg)) + (loc (and msg (compilation--message->loc msg))) last) (if (zerop n) (unless (or msg ; find message near here @@ -2154,8 +2154,7 @@ (line-end-position))) (or (setq msg (get-text-property pt 'compilation-message)) (setq pt (point))))) - (setq last (compilation--loc->file-struct - (compilation--message->loc msg))) + (setq last (compilation--loc->file-struct loc)) (if (>= n 0) (compilation-loop > compilation-next-single-property-change 1- (if (get-buffer-process (current-buffer))