From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8308: 23.3; Use utf-8 for writing abbrev file Date: Mon, 21 Mar 2011 10:50:21 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1300720062 26837 80.91.229.12 (21 Mar 2011 15:07:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2011 15:07:42 +0000 (UTC) Cc: 8308@debbugs.gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 16:07:38 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1ghl-0007xv-9S for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2011 16:07:37 +0100 Original-Received: from localhost ([127.0.0.1]:50401 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1ghj-0007BH-V0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2011 11:07:36 -0400 Original-Received: from [140.186.70.92] (port=51893 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1ghH-0006sR-Vs for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 11:07:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1ghF-0001Wy-KK for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 11:07:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1ghF-0001Wu-Iu for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 11:07:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q1gRi-00080L-Cr; Mon, 21 Mar 2011 10:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2011 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8308 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8308-submit@debbugs.gnu.org id=B8308.130071903130727 (code B ref 8308); Mon, 21 Mar 2011 14:51:02 +0000 Original-Received: (at 8308) by debbugs.gnu.org; 21 Mar 2011 14:50:31 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1gRC-0007zX-5A for submit@debbugs.gnu.org; Mon, 21 Mar 2011 10:50:30 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1gR9-0007zJ-UT; Mon, 21 Mar 2011 10:50:28 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEADsCh01Ld/X5/2dsb2JhbAClcniITbd5hWMElWk X-IronPort-AV: E=Sophos;i="4.63,219,1299474000"; d="scan'208";a="97413709" Original-Received: from 75-119-245-249.dsl.teksavvy.com (HELO pastel.home) ([75.119.245.249]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 21 Mar 2011 10:50:22 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id BAD7958AF5; Mon, 21 Mar 2011 10:50:21 -0400 (EDT) In-Reply-To: (Leo's message of "Mon, 21 Mar 2011 14:22:24 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 21 Mar 2011 10:51:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45227 Archived-At: > Is it OK to change the encoding for abbrev file to utf-8? > === modified file 'lisp/abbrev.el' > --- a/lisp/abbrev.el 2011-03-21 05:49:12 +0000 > +++ b/lisp/abbrev.el 2011-03-21 06:20:36 +0000 > @@ -225,9 +225,9 @@ > abbrev-file-name))) > (or (and file (> (length file) 0)) > (setq file abbrev-file-name)) > - (let ((coding-system-for-write 'emacs-mule)) > + (let ((coding-system-for-write 'utf-8)) > (with-temp-file file > - (insert ";;-*-coding: emacs-mule;-*-\n") > + (insert ";;-*-coding: utf-8;-*-\n") > (dolist (table > ;; We sort the table in order to ease the automatic > ;; merging of different versions of the user's abbrevs Sounds good in general, but I'm wondering whether we should worry about the presence of abbrevs which include bytes (aka eight-bit-chars). Using `utf-8-emacs' should fix those issues, but would then bump into the problem that such abbrev files wouldn't be compatible with Emacs-22. Stefan