From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#9409: 24.0.50; log-view-msg-prev, easy-mmode Date: Tue, 13 Sep 2011 17:02:09 -0400 Message-ID: References: <87aaaqpufk.fsf@pusto.de> <96bov28nrf.fsf@fencepost.gnu.org> <87zkilfrrg.fsf@pusto.de> <87k49cs05b.fsf@pusto.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1315948305 24747 80.91.229.12 (13 Sep 2011 21:11:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 13 Sep 2011 21:11:45 +0000 (UTC) Cc: 9409@debbugs.gnu.org To: Eduard Wiebe Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 13 23:11:39 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R3aGY-00009y-ND for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Sep 2011 23:11:38 +0200 Original-Received: from localhost ([::1]:46350 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3aGY-0003Kc-6R for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Sep 2011 17:11:38 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:45220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3aGV-0003KM-Gf for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2011 17:11:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3aGU-0002on-AI for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2011 17:11:35 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3aGU-0002oj-7b for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2011 17:11:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R3aKo-0008Td-Ae; Tue, 13 Sep 2011 17:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2011 21:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9409 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9409-submit@debbugs.gnu.org id=B9409.131594855232568 (code B ref 9409); Tue, 13 Sep 2011 21:16:02 +0000 Original-Received: (at 9409) by debbugs.gnu.org; 13 Sep 2011 21:15:52 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R3aKd-0008TE-PH for submit@debbugs.gnu.org; Tue, 13 Sep 2011 17:15:51 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R3aKc-0007Zc-4Y for 9409@debbugs.gnu.org; Tue, 13 Sep 2011 17:15:50 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p8DL2a6r005330; Tue, 13 Sep 2011 17:02:36 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id BD17C13007E; Tue, 13 Sep 2011 17:02:09 -0400 (EDT) In-Reply-To: <87k49cs05b.fsf@pusto.de> (Eduard Wiebe's message of "Tue, 13 Sep 2011 21:38:40 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3979=0 X-NAI-Spam-Version: 2.2.0.9286 : core <3979> : streams <681298> : uri <958703> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 13 Sep 2011 17:16:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51120 Archived-At: > I patched `easy-mmode-define-navigation' as above and tested (marked > as X) the most functions without any trouble. > * diff-mode.el > - [X] diff-hunk-prev > - [X] diff-hunk-next > - [X] diff-file-prev > - [X] diff-file-next > * log-view.el > - [X] log-view-msg-prev > - [X] log-view-msg-next > - [ ] log-view-file-prev > - [ ] log-view-file-next > * smerge-mode > - [ ] smerge-next > - [ ] smerge-prev > * cvs-status > - [X] cvs-status-next > - [X] cvs-status-prev If a problem shows up it's not going to be in the *-prev commands, but in commands that call those functions internally. So you need to check the callers of diff-hunk-prev, diff-file-prev, etc.. It's always good to check with actual testing, but it's also important to check by looking at the code. IIUC this will be safe because in the case where the behavior is changed, the function signals an error, so only callers which catch this error (with condition-case) might be affected. Stefan