From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14395: 24.3; [PATCH] new feature smie-highlight-matching-block Date: Thu, 16 May 2013 09:24:08 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1368710700 8514 80.91.229.3 (16 May 2013 13:25:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 May 2013 13:25:00 +0000 (UTC) Cc: 14395@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 16 15:24:59 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UcyB0-0000y2-Ij for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2013 15:24:58 +0200 Original-Received: from localhost ([::1]:57706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcyB0-0001cS-02 for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2013 09:24:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcyAw-0001cK-20 for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 09:24:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcyAu-0002Zu-NS for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 09:24:53 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcyAu-0002Zq-Jp for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 09:24:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UcyB4-0003xS-JN for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 09:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2013 13:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14395 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14395-submit@debbugs.gnu.org id=B14395.136871066815120 (code B ref 14395); Thu, 16 May 2013 13:25:02 +0000 Original-Received: (at 14395) by debbugs.gnu.org; 16 May 2013 13:24:28 +0000 Original-Received: from localhost ([127.0.0.1]:47180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcyAV-0003vm-Cw for submit@debbugs.gnu.org; Thu, 16 May 2013 09:24:27 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:11229) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcyAT-0003vS-BF for 14395@debbugs.gnu.org; Thu, 16 May 2013 09:24:25 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFG4rwb8/2dsb2JhbABEvw4Xc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFG4rwb8/2dsb2JhbABEvw4Xc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="12845902" Original-Received: from 184-175-6-252.dsl.teksavvy.com (HELO pastel.home) ([184.175.6.252]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 May 2013 09:24:04 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id E13D5630F3; Thu, 16 May 2013 09:24:08 -0400 (EDT) In-Reply-To: (Leo Liu's message of "Thu, 16 May 2013 11:27:31 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74325 Archived-At: >>> +(define-minor-mode smie-highlight-matching-block-mode nil >> Please provide a docstring. > Is the automatically-provided docstring good enough? Oh, right, I guess it is, sorry I forgot that I tried to make define-minor-mode DTRT. > +(define-minor-mode smie-highlight-matching-block-mode nil :global t > + (when (timerp smie--highlight-matching-block-timer) > + (cancel-timer smie--highlight-matching-block-timer)) > + (if smie-highlight-matching-block-mode > + (setq smie--highlight-matching-block-timer > + (run-with-idle-timer 0.2 t #'smie-highlight-matching-block)) > + (when (timerp smie--highlight-matching-block-timer) > + (cancel-timer smie--highlight-matching-block-timer)) > + (setq smie--highlight-matching-block-timer nil))) No, need to "cancel" twice when disabling the mode. > - (add-hook 'post-self-insert-hook > - #'smie-blink-matching-open 'append 'local) > + (if smie-highlight-matching-block-mode > + (remove-hook 'post-self-insert-hook > + #'smie-blink-matching-open 'local) > + (add-hook 'post-self-insert-hook > + #'smie-blink-matching-open 'append 'local)) I think the `remove-hook' should be done within the body of the smie-highlight-matching-block-mode minor mode rather than here. In here, you just need to wrap the add-hook within a test of smie-highlight-matching-block-mode. BTW. Is there a non-SMIE version of "highlight-matching-block-mode", which does it for parentheses? If yes, maybe smie-highlight-matching-block-mode should integrate into it. One more thought, maybe you were right that futzing around with add/remove-hook is too complicated and it's easier to check a variable. But then maybe smie-highlight-matching-block-mode should set blink-matching-paren to nil (which brings us back to whether there's a global highlight-matching-block-mode working not just for modes using SMIE). Stefan