From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16038: 24.3; latest change to with-help-window makes temp-buffer-browse useless Date: Tue, 14 Jan 2014 16:38:05 -0500 Message-ID: References: <52D14E9F.5030001@gmx.at> <52D16627.4080604@gmx.at> <52D2661A.4000105@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1389735557 31012 80.91.229.3 (14 Jan 2014 21:39:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Jan 2014 21:39:17 +0000 (UTC) Cc: 16038@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 14 22:39:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W3Bhf-0003t4-Ku for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Jan 2014 22:39:19 +0100 Original-Received: from localhost ([::1]:50842 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3Bhf-0003W9-4j for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Jan 2014 16:39:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3BhW-0003W2-2M for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 16:39:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3BhP-0002q2-8t for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 16:39:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3BhP-0002py-5K for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 16:39:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3BhO-0006Ma-Kk for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 16:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jan 2014 21:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16038 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16038-submit@debbugs.gnu.org id=B16038.138973551524386 (code B ref 16038); Tue, 14 Jan 2014 21:39:02 +0000 Original-Received: (at 16038) by debbugs.gnu.org; 14 Jan 2014 21:38:35 +0000 Original-Received: from localhost ([127.0.0.1]:50742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3Bgw-0006LG-5Z for submit@debbugs.gnu.org; Tue, 14 Jan 2014 16:38:34 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:43022) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3Bgt-0006L6-Le for 16038@debbugs.gnu.org; Tue, 14 Jan 2014 16:38:32 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 2472484CB4; Tue, 14 Jan 2014 16:38:31 -0500 (EST) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 837101E5B74; Tue, 14 Jan 2014 16:38:05 -0500 (EST) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 646B4B40D3; Tue, 14 Jan 2014 16:38:05 -0500 (EST) In-Reply-To: (Leo Liu's message of "Tue, 14 Jan 2014 12:42:31 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83504 Archived-At: > I have no idea why those hooks are needed in the first place. They were needed because temp-buffer was tied to help-buffer/window. > The commit that added this is: > revno: 39713 > committer: Miles Bader > timestamp: Tue 2001-10-09 11:17:39 +0000 > message: > Don't require `view' when compiling. > (help-with-tutorial, describe-function, describe-function-1) > (variable-at-point, describe-variable, locate-library): > Functions moved into `help-funs.el'. > (help-manyarg-func-alist): Variable moved into `help-funs.el'. > (help-mode, help-mode-setup, help-mode-finish, help-button-action) > (help-setup-xref, help-xref-following, help-make-xrefs) > (help-xref-button, help-insert-xref-button, help-xref-interned) > (help-xref-go-back, help-go-back, help-do-xref, help-follow) > (help-xref-on-pp): Functions moved into `help-mode.el' > (help-mode-map, help-xref-stack, help-xref-stack-item) > (help-highlight-p, help-highlight-face, help-back-label) > (help-xref-symbol-regexp, help-xref-mule-regexp) > (help-xref-info-regexp): Variables moved into `help-mode.el'. > (help-symbol, help-back, help-info, help-customize-variable) > (help-function-def, help-variable-def): > Button-types moved into `help-mode.el'. > (load-symbol-file-load-history, symbol-file): > Functions moved into `subr.el'. > (symbol-file-load-history-loaded): Variable moved into `subr.el'. > (view-lossage): Call `help-setup-xref' instead of doing it manually. Are you sure? This looks like a commit that mostly moves code around. I think those hook functions are older. > Now that with-help-window is implemented on top of > with-temp-buffer-window, it seems they are useless. That could be. But someone needs to look in detail at whether that's the case or not. > The whole thing also looks odd how temp-buffer is tied to > help-buffer/window etc? You know, hysterical raisins'n stuff. Stefan