From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16818: Acknowledgement (Undo in region after markers in undo history relocated) Date: Thu, 13 Mar 2014 10:35:05 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394722037 26297 80.91.229.3 (13 Mar 2014 14:47:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Mar 2014 14:47:17 +0000 (UTC) Cc: 16818@debbugs.gnu.org To: Barry OReilly Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 13 15:47:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WO6uq-00005A-NO for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Mar 2014 15:47:24 +0100 Original-Received: from localhost ([::1]:39535 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO6uq-0002mY-DG for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Mar 2014 10:47:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO6uf-0002kS-U7 for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 10:47:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WO6uY-0002gY-KO for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 10:47:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO6jr-0007SC-5G for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 10:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WO6jq-0007Ef-I5 for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 10:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Mar 2014 14:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16818 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16818-submit@debbugs.gnu.org id=B16818.139472131127741 (code B ref 16818); Thu, 13 Mar 2014 14:36:02 +0000 Original-Received: (at 16818) by debbugs.gnu.org; 13 Mar 2014 14:35:11 +0000 Original-Received: from localhost ([127.0.0.1]:36001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WO6j0-0007DI-Qp for submit@debbugs.gnu.org; Thu, 13 Mar 2014 10:35:11 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:46027) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WO6ix-0007D4-2C for 16818@debbugs.gnu.org; Thu, 13 Mar 2014 10:35:08 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSSIHgbBLY0Ng30DpHqBXoMTgUo X-IPAS-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSSIHgbBLY0Ng30DpHqBXoMTgUo X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="51729653" Original-Received: from 76-10-154-114.dsl.teksavvy.com (HELO pastel.home) ([76.10.154.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Mar 2014 10:35:05 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id AAF7F60293; Thu, 13 Mar 2014 10:35:05 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Thu, 13 Mar 2014 09:24:28 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86823 Archived-At: >> Your counter proposal is a step from the root. For instance, the >> markers within the mark rings will not adjust correctly, whilst with >> my patch they will. > Can you give an example incorrect adjustment? Oh, I think I see: with the current code, the mark-ring gets copies of markers and those copies are made "late", so if you do "C-SPC, some deletion around point, and then C-SPC", a new marker for the first C-SPC is pushed on the mark-ring, but the undo-log has an adjustment for mark-marker rather than for that new marker. IOW, I think the primitive-undo fix is needed and your fix is also needed. I think your fix is too risky for the 24.4, tho (IOW, please wait for the trunk to re-open before installing it). The primitive-undo fix should be safe enough for 24.4, so if you want to code this up and install it, feel free. Stefan