* bug#17325: 24.3.90; can not font-lock @ function
@ 2014-04-23 13:55 Leo Liu
2014-04-23 14:52 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Leo Liu @ 2014-04-23 13:55 UTC (permalink / raw)
To: 17325
Try this code snippet in emacs-lisp-mode and you should see the function
name after @ not font-locked:
(defun who-@-how ()
)
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#17325: 24.3.90; can not font-lock @ function
2014-04-23 13:55 bug#17325: 24.3.90; can not font-lock @ function Leo Liu
@ 2014-04-23 14:52 ` Stefan Monnier
2014-04-23 15:27 ` Leo Liu
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2014-04-23 14:52 UTC (permalink / raw)
To: Leo Liu; +Cc: 17325
> Try this code snippet in emacs-lisp-mode and you should see the function
> name after @ not font-locked:
> (defun who-@-how ()
> )
That's because of its "prefix" syntax for use in ,@.
I guess we could change its syntax from "'" to "_ p".
Can someone try it out and install that change if it seems to work well?
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#17325: 24.3.90; can not font-lock @ function
2014-04-23 14:52 ` Stefan Monnier
@ 2014-04-23 15:27 ` Leo Liu
2014-04-23 17:35 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Leo Liu @ 2014-04-23 15:27 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 17325
On 2014-04-23 10:52 -0400, Stefan Monnier wrote:
> That's because of its "prefix" syntax for use in ,@.
> I guess we could change its syntax from "'" to "_ p".
> Can someone try it out and install that change if it seems to work well?
Seems to work well. Since this is a regression, I suppose it should be
in emacs-24? If so I'll take care of this tomorrow.
Leo
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#17325: 24.3.90; can not font-lock @ function
2014-04-23 15:27 ` Leo Liu
@ 2014-04-23 17:35 ` Stefan Monnier
2014-04-24 1:04 ` Leo Liu
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2014-04-23 17:35 UTC (permalink / raw)
To: Leo Liu; +Cc: 17325
>> That's because of its "prefix" syntax for use in ,@.
>> I guess we could change its syntax from "'" to "_ p".
>> Can someone try it out and install that change if it seems to work well?
> Seems to work well. Since this is a regression, I suppose it should be
> in emacs-24? If so I'll take care of this tomorrow.
Not sure why you think it's a regression, but yes you can install it in
emacs-24.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#17325: 24.3.90; can not font-lock @ function
2014-04-23 17:35 ` Stefan Monnier
@ 2014-04-24 1:04 ` Leo Liu
2014-04-24 13:20 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Leo Liu @ 2014-04-24 1:04 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 17325
On 2014-04-23 13:35 -0400, Stefan Monnier wrote:
> Not sure why you think it's a regression, but yes you can install it in
> emacs-24.
I mean the code snippet is font-locked correctly in 24.3.
BTW, in emacs-lisp-mode-syntax-table why are all entries end with some
whitespaces i.e. instead of
(modify-syntax-entry ?@ "'" table)
it uses:
(modify-syntax-entry ?@ "' " table)
Leo
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#17325: 24.3.90; can not font-lock @ function
2014-04-24 1:04 ` Leo Liu
@ 2014-04-24 13:20 ` Stefan Monnier
2014-04-25 5:04 ` Leo Liu
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2014-04-24 13:20 UTC (permalink / raw)
To: Leo Liu; +Cc: 17325
>> Not sure why you think it's a regression, but yes you can install it in
>> emacs-24.
> I mean the code snippet is font-locked correctly in 24.3.
Aha, didn't realize that. Not sure why that changed.
> BTW, in emacs-lisp-mode-syntax-table why are all entries end with some
> whitespaces i.e. instead of
> (modify-syntax-entry ?@ "'" table)
> it uses:
> (modify-syntax-entry ?@ "' " table)
It makes no difference, but this style was very common. It's probably
because syntax strings are "positional" (the first char has a meaning,
the second another one, the rest yet another) so using "' " is saying
explicitly "no p/b/1/2/3/4".
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#17325: 24.3.90; can not font-lock @ function
2014-04-24 13:20 ` Stefan Monnier
@ 2014-04-25 5:04 ` Leo Liu
0 siblings, 0 replies; 7+ messages in thread
From: Leo Liu @ 2014-04-25 5:04 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 17325-done
Fixed in 24.3.91
On 2014-04-24 09:20 -0400, Stefan Monnier wrote:
> It makes no difference, but this style was very common. It's probably
> because syntax strings are "positional" (the first char has a meaning,
> the second another one, the rest yet another) so using "' " is saying
> explicitly "no p/b/1/2/3/4".
Thanks for this info.
Leo
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-04-25 5:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-23 13:55 bug#17325: 24.3.90; can not font-lock @ function Leo Liu
2014-04-23 14:52 ` Stefan Monnier
2014-04-23 15:27 ` Leo Liu
2014-04-23 17:35 ` Stefan Monnier
2014-04-24 1:04 ` Leo Liu
2014-04-24 13:20 ` Stefan Monnier
2014-04-25 5:04 ` Leo Liu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).