unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ed Avis <eda@waniasset.com>
Cc: "'19161@debbugs.gnu.org'" <19161@debbugs.gnu.org>
Subject: bug#19161: 24.4; vc-mode reload on commit - don't jump to start of buffer
Date: Wed, 26 Nov 2014 22:28:47 -0500	[thread overview]
Message-ID: <jwvlhmxgwkw.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <7E039918541B4C4183BFDB8F015C74302E422FA7@WCL-EXCH02.wcl.local> (Ed Avis's message of "Tue, 25 Nov 2014 15:09:16 +0000")

> It does appear to be moving point to the Id: dropping after commit.
> I just saw this behaviour again - let me have another go at making
> a recipe from emacs -Q.

I think it's probably expected behavior:

When a file is reverted, the file is compared to the buffer and only the
part between the first and the last changed bytes is replaced.

So, in your case, the "first changed byte" is at the "$Id" thingy, and
if the last changed byte is somewhere further down in the middle of the
file (or worse, near the end), then any marker (including "the point",
and window-points) will be moved to either right before or right after
the replaced text.

We could do better, by doing an actual "diff" and then applying the
patch, but someone would have to write it.


        Stefan





  reply	other threads:[~2014-11-27  3:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 11:32 bug#19161: 24.4; vc-mode reload on commit - don't jump to start of buffer Ed Avis
2014-11-24 15:00 ` Stefan Monnier
2014-11-24 17:30   ` Ed Avis
2014-11-25  1:54     ` Stefan Monnier
2014-11-25 15:09     ` Ed Avis
2014-11-27  3:28       ` Stefan Monnier [this message]
2014-11-27 11:28         ` Ed Avis
2014-12-11 21:09           ` Stefan Monnier
2014-12-12  8:12             ` Ed Avis
2014-11-24 16:59 ` Glenn Morris
2014-11-24 17:06   ` Ed Avis
2014-12-15  8:07 ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlhmxgwkw.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=19161@debbugs.gnu.org \
    --cc=eda@waniasset.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).