From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort Date: Sat, 21 Nov 2015 21:23:31 -0500 Message-ID: References: <20151116211021.12530.98760@vcs.savannah.gnu.org> <564CA7FE.7030709@cornell.edu> <5650EECB.1020809@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448159123 5616 80.91.229.3 (22 Nov 2015 02:25:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 02:25:23 +0000 (UTC) Cc: John Wiegley , 21688@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 22 03:25:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0KL0-0001PJ-8D for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Nov 2015 03:25:10 +0100 Original-Received: from localhost ([::1]:54507 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0KKz-00034Z-LJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Nov 2015 21:25:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0KKv-00032x-Co for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2015 21:25:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0KKs-0001ah-8g for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2015 21:25:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0KKs-0001aN-55 for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2015 21:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a0KKr-0004of-SK for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2015 21:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Nov 2015 02:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21688 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21688-submit@debbugs.gnu.org id=B21688.144815904918318 (code B ref 21688); Sun, 22 Nov 2015 02:25:01 +0000 Original-Received: (at 21688) by debbugs.gnu.org; 22 Nov 2015 02:24:09 +0000 Original-Received: from localhost ([127.0.0.1]:47510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0KK0-0004lN-R4 for submit@debbugs.gnu.org; Sat, 21 Nov 2015 21:24:09 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:45062) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0KJg-0004jp-RF for 21688@debbugs.gnu.org; Sat, 21 Nov 2015 21:24:07 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id tAM2NV1b019250; Sat, 21 Nov 2015 21:23:31 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 6E016AE594; Sat, 21 Nov 2015 21:23:31 -0500 (EST) In-Reply-To: <5650EECB.1020809@cs.ucla.edu> (Paul Eggert's message of "Sat, 21 Nov 2015 14:23:07 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5497=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5497> : inlines <4017> : streams <1542018> : uri <2087292> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109043 Archived-At: > Perhaps Stefan or someone else will be able to knock a few cycles free to > fix this. I'm afraid I've been spending most of my time elsewhere in Emacs > recently, what with the new module code and all. My crystal ball tells me that maybe it's just the following hunk which is to blame: diff --git a/src/syntax.c b/src/syntax.c index 5b0ec6d..f939a76 100644 --- a/src/syntax.c +++ b/src/syntax.c @@ -514,7 +514,6 @@ update_syntax_table_forward (ptrdiff_t charpos, bool init, { eassert (NILP (object)); eassert (charpos >= gl_state.e_property); - parse_sexp_propertize (charpos); } else { I think this hunk is just a mistake that was introduced during the "back&forth" that took place when you added and then removed the "bool propertize" argument. Stefan