From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: John Wiegley <johnw@newartisans.com>, 21688@debbugs.gnu.org
Subject: bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort
Date: Sat, 21 Nov 2015 21:23:31 -0500 [thread overview]
Message-ID: <jwvlh9qkc3s.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <5650EECB.1020809@cs.ucla.edu> (Paul Eggert's message of "Sat, 21 Nov 2015 14:23:07 -0800")
> Perhaps Stefan or someone else will be able to knock a few cycles free to
> fix this. I'm afraid I've been spending most of my time elsewhere in Emacs
> recently, what with the new module code and all.
My crystal ball tells me that maybe it's just the following hunk which
is to blame:
diff --git a/src/syntax.c b/src/syntax.c
index 5b0ec6d..f939a76 100644
--- a/src/syntax.c
+++ b/src/syntax.c
@@ -514,7 +514,6 @@ update_syntax_table_forward (ptrdiff_t charpos, bool init,
{
eassert (NILP (object));
eassert (charpos >= gl_state.e_property);
- parse_sexp_propertize (charpos);
}
else
{
I think this hunk is just a mistake that was introduced during the
"back&forth" that took place when you added and then removed the "bool
propertize" argument.
Stefan
prev parent reply other threads:[~2015-11-22 2:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151116211021.12530.98760@vcs.savannah.gnu.org>
[not found] ` <E1ZyR2b-0003Gm-BV@vcs.savannah.gnu.org>
[not found] ` <564CA7FE.7030709@cornell.edu>
[not found] ` <m2bnarp8je.fsf@newartisans.com>
2015-11-21 22:23 ` bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort Paul Eggert
2015-11-22 2:23 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlh9qkc3s.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=21688@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=johnw@newartisans.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).