From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#25644: 26.0.50; Problematic transient map in minibuffer-force-complete Date: Tue, 07 Feb 2017 11:23:43 -0500 Message-ID: References: <87lgti80cs.fsf@drachen> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1486484658 25188 195.159.176.226 (7 Feb 2017 16:24:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 7 Feb 2017 16:24:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 25644@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 07 17:24:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cb8Yv-0006II-G6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Feb 2017 17:24:13 +0100 Original-Received: from localhost ([::1]:55189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cb8Z0-0007NB-RW for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Feb 2017 11:24:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cb8Yn-0007LR-KP for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2017 11:24:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cb8Yk-0007Yn-CR for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2017 11:24:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60980) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cb8Yk-0007YI-9Q for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2017 11:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cb8Yk-0003H2-3g for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2017 11:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Feb 2017 16:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.148648464112580 (code B ref -1); Tue, 07 Feb 2017 16:24:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Feb 2017 16:24:01 +0000 Original-Received: from localhost ([127.0.0.1]:59179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cb8Yj-0003Gn-AY for submit@debbugs.gnu.org; Tue, 07 Feb 2017 11:24:01 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cb8Yg-0003GZ-Ta for submit@debbugs.gnu.org; Tue, 07 Feb 2017 11:23:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cb8YZ-0007KA-PF for submit@debbugs.gnu.org; Tue, 07 Feb 2017 11:23:53 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:53528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cb8YZ-0007Je-MJ for submit@debbugs.gnu.org; Tue, 07 Feb 2017 11:23:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cb8YX-0007AL-S3 for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2017 11:23:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cb8YU-0007EE-Ey for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2017 11:23:49 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:36816) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cb8YU-0007Bp-8f for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2017 11:23:46 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AGKQAu3EVY//7rSC1dGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+EW4VUnAImAZRWggiGHAQCAoIRQhIBAgEBAQEBAQFiKIRpAQQBViMFCws0EhQYDSSIegitFItEAQEBBwIlixmKKQWPfIpqmxqGOpIPJQEweBMOhXMgiS0BAQE X-IPAS-Result: A0AGKQAu3EVY//7rSC1dGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+EW4VUnAImAZRWggiGHAQCAoIRQhIBAgEBAQEBAQFiKIRpAQQBViMFCws0EhQYDSSIegitFItEAQEBBwIlixmKKQWPfIpqmxqGOpIPJQEweBMOhXMgiS0BAQE X-IronPort-AV: E=Sophos;i="5.33,749,1477972800"; d="scan'208";a="292268077" Original-Received: from 45-72-235-254.cpe.teksavvy.com (HELO pastel.home) ([45.72.235.254]) by smtp.teksavvy.com with ESMTP; 07 Feb 2017 11:23:44 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id B33B9657EE; Tue, 7 Feb 2017 11:23:43 -0500 (EST) In-Reply-To: <87lgti80cs.fsf@drachen> (Michael Heerdegen's message of "Tue, 07 Feb 2017 16:52:19 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129076 Archived-At: > (define-key icomplete-minibuffer-map [return] > #'icomplete-force-complete-and-exit) FWIW, I think this should be (define-key icomplete-minibuffer-map [?\r] #'icomplete-force-complete-and-exit) aka (define-key icomplete-minibuffer-map (kbd "RET") #'icomplete-force-complete-and-exit) > M-x epatch > - Answer y to the question whether the patch is in a buffer > - Hit RET to confirm the suggested default > Note that nothing happens, or you get a `ding'. The second RET works > OTOH. Without the "Setup" part it works as expected however. > I debugged a bit and found that in the first place, the transient map > installed by minibuffer-force-complete shadows the (my) binding of RET. > Someone with insight into that code (Stefan, probably): am I'm doing > something forbidden, or should we improve that code? I can't see anything in your Setup code which justifies the behavior you're seeing, so it seems like a bug somewhere. Probably in the case of force-complete-and-exit, we should prevent/disable the transient-map. BTW, if you do M-x epatch - Answer y to the question whether the patch is in a buffer - C-h k RET what does it say? Stefan