From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#36598: 26.1; (error "=?UTF-8?Q?=E2=80=98/tmp/emacs1000=E2=80=99?= is not a safe directory because it is a symlink") Date: Mon, 15 Jul 2019 09:04:22 -0400 Message-ID: References: <87muhkr79y.fsf@silk.nichework.com> <87k1cmwnu6.fsf@mouse.gnus.org> <44a502116d2c0568d120b7328913b26a@russet.org.uk> <20a62c04ad67dc64665b32d7a31cfe8b@russet.org.uk> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="260245"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 36598@debbugs.gnu.org, mah@everybody.org To: phillip.lord@russet.org.uk Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 15 15:05:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hn0fJ-0015N1-P2 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jul 2019 15:05:13 +0200 Original-Received: from localhost ([::1]:38382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hn0fH-0002qL-OP for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jul 2019 09:05:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43891) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hn0f9-0002pz-Qa for bug-gnu-emacs@gnu.org; Mon, 15 Jul 2019 09:05:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hn0f8-0001qT-P8 for bug-gnu-emacs@gnu.org; Mon, 15 Jul 2019 09:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38060) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hn0f8-0001qF-LH for bug-gnu-emacs@gnu.org; Mon, 15 Jul 2019 09:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hn0f7-0004Qo-W0 for bug-gnu-emacs@gnu.org; Mon, 15 Jul 2019 09:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jul 2019 13:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36598 X-GNU-PR-Package: emacs Original-Received: via spool by 36598-submit@debbugs.gnu.org id=B36598.156319587416988 (code B ref 36598); Mon, 15 Jul 2019 13:05:01 +0000 Original-Received: (at 36598) by debbugs.gnu.org; 15 Jul 2019 13:04:34 +0000 Original-Received: from localhost ([127.0.0.1]:46878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hn0ef-0004Pw-JR for submit@debbugs.gnu.org; Mon, 15 Jul 2019 09:04:33 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hn0eb-0004Ph-PP for 36598@debbugs.gnu.org; Mon, 15 Jul 2019 09:04:30 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 99B3F100951; Mon, 15 Jul 2019 09:04:24 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5DE221005CA; Mon, 15 Jul 2019 09:04:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1563195863; bh=1dadSI8qEa8id5dvXPV6u8NfAQqEy+UYJxjK+ZZbolM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dRc4pC7a/T1db8Tyc2agEU5qsNxj/aaHF70+47mx49CbQldBehYkXB0pHiL5zJ1ME J6d5o5XFz2op2TJ58stI0YfqxxXJnc03mtOrhrnum9bEbPpUg14AnEqvGFleYi77G+ 0ys0sYLa0EL8TK2tCGfACgt1bQHOKoc7IdlQzQvnD5q6FPYZzuhd5u9BV7iRNviwDj X98/pLtArhOjpvghquMxQMkMrp5Bk/RVVTYlbq+0hUjbXdayaPa7Mcyf0PXdFfrGGj 7yX/2MKnEaX3I9ZHJtbgZtO21gokgivb1IHcblL+QPkkhF14HmE12zUu0sNY+JTLiT FUjmwS0WqAtqQ== Original-Received: from pastel (104-222-123-229.cpe.teksavvy.com [104.222.123.229]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 23B07120642; Mon, 15 Jul 2019 09:04:23 -0400 (EDT) In-Reply-To: <20a62c04ad67dc64665b32d7a31cfe8b@russet.org.uk> (phillip lord's message of "Sun, 14 Jul 2019 20:11:31 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163111 Archived-At: >> Commit b663c837249 (in May) which says "Cosmetic changes" is the one >> that introduced this code? >> >> (let ((olddir (or (getenv "TMPDIR") "/tmp"))) >> (when (and (equal dir (format "%s/emacs" (getenv >> "XDG_RUNTIME_DIR"))) >> (file-writable-p olddir)) >> (let ((link (format "%s/emacs%d" olddir (user-uid)))) >> (unless (file-directory-p link) >> ;; We're using the new location, so try and setup a symlink >> from >> ;; the old location, in case we want to use an >> old emacsclient. >> ;; FIXME: Check that it's safe to use! >> (make-symbolic-link dir link t))))) >> >> And instead of making things work with an old emacsclient, it breaks the >> Emacs 26 emacsclient? > > Nearly. I think it breaks emacs-26 not the emacsclient. I haven't check the > emacsclient code, but I guess Stefan was > aiming for the situation when someone is using (say) emacsclient-26 with > emacs-27. Indeed (it's Debian/s /usr/bin/emacsclient accessing my hand-built Emacs-27 server). >> Stefan, was this checked in by mistake? Definitely, Stefan