From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#24585: 25.1; avoid hack in ggtags.el to run compilation-auto-jump timer Date: Fri, 04 Sep 2020 10:29:15 -0400 Message-ID: References: <83twcrks7q.fsf@gnu.org> <83int5jpde.fsf@gnu.org> <87imctbtfc.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37955"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 24585@debbugs.gnu.org, Leo Liu To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 04 16:30:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kECjH-0009jj-Qp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 16:30:16 +0200 Original-Received: from localhost ([::1]:44278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kECjE-0004sG-Ei for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 10:30:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kECj5-0004p8-80 for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 10:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kECj4-0003il-Uf for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 10:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kECj4-0005l3-PT for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 10:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Sep 2020 14:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24585 X-GNU-PR-Package: emacs Original-Received: via spool by 24585-submit@debbugs.gnu.org id=B24585.159922976422069 (code B ref 24585); Fri, 04 Sep 2020 14:30:02 +0000 Original-Received: (at 24585) by debbugs.gnu.org; 4 Sep 2020 14:29:24 +0000 Original-Received: from localhost ([127.0.0.1]:40259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kECiS-0005jt-9x for submit@debbugs.gnu.org; Fri, 04 Sep 2020 10:29:24 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kECiR-0005jh-Fj for 24585@debbugs.gnu.org; Fri, 04 Sep 2020 10:29:23 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0CBFB10025D; Fri, 4 Sep 2020 10:29:18 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BF6D3100241; Fri, 4 Sep 2020 10:29:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599229755; bh=IT+TLBPTHNXZwPAKDyf++tqqOGik35SGfUmde4yxVu4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KxP2qnvkJAajM27QkCqnLQP7cF3W7X5qZJ9bSLASrdeFpyAXEhYTEU1/hcu93tmIa +k+lu4XV7bGPcdShsfeLtYKISbXTJ9uIfOq7NbzpbnNU3iIoycCeKcQ18tvM4gJZwS IEsJ+JQ5akPrl2/QJ3yli+kAbvUTDn29LsNUiDLLqZ0lcDSFS9xWgqEKQk+bVF3L3s vB/GT1A7heGyfP6Oy6XsePhImViei7WFP0nlWmJ6ArxocfgBB/BoeU6TTIuoFSpr9B PJkroBC+yFWg3uQ9At++QyWGSl7CQFSkbtPNx5pQmHY1wBR5hy+AfBf2NxbwWopXxK 9ADXVPvY56BYg== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9406C1203FD; Fri, 4 Sep 2020 10:29:15 -0400 (EDT) In-Reply-To: <87imctbtfc.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 04 Sep 2020 14:47:03 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187144 Archived-At: > This was the final message in this bug report, but looking at the patch > that supposedly fixes the problem, I don't understand how it makes a > difference: Putting (match-beginning) in a buffer-local variable > instead of passing it in directly seems like a no-op? This was too long ago and got moved to write-only swap space, and I haven't had time to dig into it now to recover the lost context, but I can see a potential case where it makes a difference, which is if the timer is set multiple times before it gets a chance to be run: with the new code only one of the timers will actually be executed. > Checking whether the buffer is alive in compilation-auto-jump seems like > a good idea, though (any async function that switches to a buffer should > check whether it's alive first). Indeed, Stefan